🐛(backend) add link to "Open" text in recording email#1101
Open
UGilfoyle wants to merge 1 commit intosuitenumerique:mainfrom
Open
🐛(backend) add link to "Open" text in recording email#1101UGilfoyle wants to merge 1 commit intosuitenumerique:mainfrom
UGilfoyle wants to merge 1 commit intosuitenumerique:mainfrom
Conversation
Added a hyperlink to the "Open" text in step 1 of the recording notification email instructions. Previously, "Open" was plain text and users could only access their recording via the button below. Now the text itself is a clickable link, improving accessibility for email clients that may not render the button properly. Updated MJML source template and all 4 locale files (en, fr, de, nl).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The "Open" text in step 1 of the recording notification email instructions was plain text — not a clickable link. Users whose email clients didn't properly render the button below had no way to access their recording from the instructions.
Fixes the issue where the email says "Click the Open button below" but "Open" itself wasn't linked.
Proposal
Wrapped "Open" in step 1 with an
<a href="{{link}}">tag in the MJML source templateChanged wording from "button" to "link" to reflect the new behavior
Updated all 4 locale translation files (en, fr, de, nl)
Rebuilt compiled HTML and plain text templates
MJML source template updated
Locale files updated (en, fr, de, nl)
Templates rebuilt via
npm run buildChangelog entry added