Skip to content

feat(deps): upgrade BlockNote from 0.47.3 to 0.48.1#2224

Closed
StephanMeijer wants to merge 1 commit into
suitenumerique:mainfrom
StephanMeijer:feature/blocknote-upgrade-0.48.1
Closed

feat(deps): upgrade BlockNote from 0.47.3 to 0.48.1#2224
StephanMeijer wants to merge 1 commit into
suitenumerique:mainfrom
StephanMeijer:feature/blocknote-upgrade-0.48.1

Conversation

@StephanMeijer
Copy link
Copy Markdown
Collaborator

@StephanMeijer StephanMeijer commented Apr 16, 2026

Summary

What changed

package.json

All 9 @blocknote/* packages bumped 0.47.30.48.1:
@blocknote/core, @blocknote/react, @blocknote/mantine, @blocknote/code-block, @blocknote/xl-ai, @blocknote/xl-docx-exporter, @blocknote/xl-multi-column, @blocknote/xl-odt-exporter, @blocknote/xl-pdf-exporter

styles.tsx (1 line)

BlockNote 0.48.0 breaking change: theme CSS variables (colors, fonts) must now target .bn-root instead of .bn-container. .bn-root wraps both the editor and its floating UI (menus, toolbars); .bn-container is now layout-only.

- & > .bn-container {
+ & > .bn-root {
    --bn-colors-editor-text: var(--c--contextuals--content--semantic--neutral--primary);
    --bn-colors-side-menu: var(--c--contextuals--content--semantic--neutral--tertiary);
  }

Fix for #1934

BlockNote 0.48.1 includes TypeCellOS/BlockNote#2651, which fixes the DOCX exporter defaulting to en-US when no locale is passed. The <w:lang> element is now omitted entirely when no locale is provided, letting Word/LibreOffice auto-detect the document language from content — per ECMA-376 §17.3.2.20.

Verification

  • yarn build — clean, no TypeScript errors
  • yarn test — 192/192 tests pass
  • yarn lint — clean
  • ✅ Editor, slash menu, formatting toolbar, comments — all working (live QA)
  • ✅ DOCX w:lang fix confirmed in @blocknote/xl-docx-exporter@0.48.1 package source

Assisted by Claude Sonnet 4.6

@StephanMeijer StephanMeijer requested review from AntoLC, Ovgodd and Copilot and removed request for AntoLC and Copilot April 16, 2026 18:46
/**
* Token Mantime
*/
& > .bn-container {
Copy link
Copy Markdown
Collaborator Author

@StephanMeijer StephanMeijer Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nperez0111 Can you validate this change? 🙏

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this would be right

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ceeb95d1-237d-447b-8203-952703ff3ac3

📥 Commits

Reviewing files that changed from the base of the PR and between 3ef6306 and f308af6.

⛔ Files ignored due to path filters (1)
  • src/frontend/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (3)
  • src/frontend/apps/impress/package.json
  • src/frontend/apps/impress/src/features/docs/doc-editor/styles.tsx
  • src/frontend/servers/y-provider/package.json
✅ Files skipped from review due to trivial changes (2)
  • src/frontend/servers/y-provider/package.json
  • src/frontend/apps/impress/package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/frontend/apps/impress/src/features/docs/doc-editor/styles.tsx

Walkthrough

This pull request updates several @blocknote/* package versions from 0.47.3 to 0.48.1 in src/frontend/apps/impress/package.json (including code-block, core, mantine, react, xl-ai, xl-docx-exporter, xl-multi-column, xl-odt-exporter, xl-pdf-exporter). It also updates @blocknote/server-util (dependencies) and @blocknote/core (devDependencies) from 0.47.3 to 0.48.1 in src/frontend/servers/y-provider/package.json. In src/frontend/apps/impress/src/features/docs/doc-editor/styles.tsx a selector was changed from & > .bn-container to & > .bn-root, moving two CSS custom-property assignments and correcting a comment typo. No exported/public API declarations were modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Additional context

Linked issue #1934 reports DOCX exports defaulting the spell-check language to English; these dependency updates may be related, but the diff contains no explicit logic changes addressing export language or document language metadata.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: upgrading BlockNote dependencies from version 0.47.3 to 0.48.1.
Description check ✅ Passed The description comprehensively documents all changes, including dependency upgrades, CSS selector migration, and the fix for issue #1934 with supporting verification.
Linked Issues check ✅ Passed The PR fully addresses issue #1934 by upgrading to BlockNote 0.48.1, which includes the fix to omit the <w:lang> element when no locale is provided, allowing proper language auto-detection in Word/LibreOffice.
Out of Scope Changes check ✅ Passed All changes in the PR are directly related to the BlockNote upgrade and issue #1934 fix: dependency version bumps, CSS selector migration for theming changes, and no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades BlockNote dependencies to 0.48.1, adapts editor theming CSS for the .bn-root selector change, and relies on the upstream DOCX exporter fix to stop forcing an English spellchecker by default.

Changes:

  • Bumped 9 @blocknote/* packages from 0.47.30.48.1 in the Impress app workspace.
  • Updated editor theming selector from .bn-container to .bn-root per BlockNote 0.48.0 breaking change.
  • Refreshed yarn.lock for updated BlockNote (and related) dependency graph.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/frontend/apps/impress/package.json Updates BlockNote package versions to 0.48.1 for the app workspace.
src/frontend/apps/impress/src/features/docs/doc-editor/styles.tsx Updates theming CSS selector to target .bn-root.
src/frontend/yarn.lock Lockfile updates for BlockNote 0.48.1 and transitive dependency changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/frontend/apps/impress/package.json
@@ -15,7 +15,7 @@ export const cssEditor = css`
/**
* Token Mantime
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The block comment says "Token Mantime"; this looks like a typo for "Mantine" (the rest of the file targets Mantine classes). Renaming it would avoid confusion when searching for Mantine-related styling.

Suggested change
* Token Mantime
* Token Mantine

Copilot uses AI. Check for mistakes.
@StephanMeijer StephanMeijer force-pushed the feature/blocknote-upgrade-0.48.1 branch from 96af403 to 3ef6306 Compare April 16, 2026 19:00
Bump all 11 @blocknote/* packages across impress and y-provider.
Migrate theme CSS variables from .bn-container to .bn-root (0.48.0 breaking change).
Fix comment typo: Mantime → Mantine.

Fixes suitenumerique#1934

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
@StephanMeijer StephanMeijer force-pushed the feature/blocknote-upgrade-0.48.1 branch from 3ef6306 to f308af6 Compare April 16, 2026 22:46
@virgile-dev
Copy link
Copy Markdown
Collaborator

hey @StephanMeijer
Thanks for taking care of the automatic corrector language issue in BlockNote.
Upgrading BlockNote in Docs is a very sensitive operation, it can introduce breaking changes that need to be carefully reviewed by a front-end developper, using AI for this is not fit.
Your fix will be avaiblable to users when we upgrade BlockNote in Docs, there is no rush as it's a non blocking bug and user can select the language of their choice in their prefered text editor.
Cheers,

@StephanMeijer
Copy link
Copy Markdown
Collaborator Author

hey @StephanMeijer Thanks for taking care of the automatic corrector language issue in BlockNote. Upgrading BlockNote in Docs is a very sensitive operation, it can introduce breaking changes that need to be carefully reviewed by a front-end developper, using AI for this is not fit. Your fix will be avaiblable to users when we upgrade BlockNote in Docs, there is no rush as it's a non blocking bug and user can select the language of their choice in their prefered text editor. Cheers,

Ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs' export in docx format : corrector in english and not in the language of the document

4 participants