Merged
Conversation
vbarua
reviewed
Feb 27, 2026
| import pyarrow.substrait as pa_substrait | ||
| import pytest | ||
|
|
||
| pytest.importorskip("sqloxide") |
Contributor
Author
There was a problem hiding this comment.
it tries to import sqloxide and skips the tests in the file if import is unsuccessful rather than fail. it's a roundabout way to say that this file will be skipped for py3.14 because sqloxide is left out of py3.14 env
vbarua
approved these changes
Feb 27, 2026
Member
vbarua
left a comment
vbarua
left a comment
There was a problem hiding this comment.
Seems reasonable to me. Did leave one question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds support for python 3.14.
sqlmodule tests are skipped as sqloxide still hasn't upgraded.