feat: test multiple substrait versions in ci#151
feat: test multiple substrait versions in ci#151tokoko wants to merge 1 commit intosubstrait-io:mainfrom
Conversation
|
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
|
We will have to alter test command and versions once we actually add new versions and move antlr and extensions out of the repo as well. |
| matrix: | ||
| os: [macos-latest, ubuntu-latest, windows-latest] | ||
| python: ["3.10", "3.11", "3.12", "3.13"] | ||
| substrait_version: ["0.78.0", "0.79.0"] |
There was a problem hiding this comment.
What's the benefit of testing multiple substrait versions?
There was a problem hiding this comment.
I'm assuming we'll eventually have some sort of a policy regarding supported substrait versions. This would ensure changes don't accidentally break compatibility with older substrait versions. if you think that's premature, we can forget about it for now, at least until version 1.
There was a problem hiding this comment.
I think it's a bit premature tbh. We actually just talked a bit at the last sync about starting to remove some deprecated features/fields, and a check like this would potentially add some friction to that.
2 participants
ci is able to test multiple versions of substrait.