fix: javadoc for the isthmus library#645
Conversation
5398c36 to
dfc8d54
Compare
eb2f225 to
422ffb2
Compare
abafe1d to
7776b17
Compare
7776b17 to
931bdd6
Compare
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
|
I think this change is broadly good, but I worry about such a large diff in one small PR. I am not remotely familiar with the calcite stuff, so I wouldn't be able to judge the accuracy of these comments. But I wonder if it would be easier to get this one in if it was broken up over multiple PRs, perhaps talking a file or two at a time. What do you think about that? |
Sadly I've not been able to pay much attention to this PR in the last couple of months due to other priorities - but yes I had this exact conversation with @nielspardon; the next PR with JavaDoc will just have 1 class :-) |
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
No description provided.