Autoprefixer Integration#223
Open
jescalan wants to merge 1 commit intostylus:masterfrom
jescalan:autoprefixer
Open
Autoprefixer Integration#223jescalan wants to merge 1 commit intostylus:masterfrom jescalan:autoprefixer
jescalan wants to merge 1 commit intostylus:masterfrom
jescalan:autoprefixer
Conversation
Collaborator
|
This is a nice start, but the tests are failing and we should gut out all the prefixing that nib does before we merge this. That way we're not prefixing twice, which could either cause performance degradation, errors, or both. |
Author
|
Definitely, this is not intended as a full implementation, just getting the ball rolling. What are your thoughts on how to handle gradients? Autoprefixer has handling for gradients, but I know nib does image replacement as well... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will integrate autoprefixer into nib by default, and remove a lot of vendor maintenance stuff. Initial commit here just adds it to the pipeline, a lot of work still left to carefully strip the vendor-handling pieces from nib without breaking anything or removing functionality like the node-canvas stuff.