fix: show apps hint command in stripe --help#1601
Open
yahanxing-stripe wants to merge 2 commits into
Open
Conversation
vzhang-stripe
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue that stripe apps was not appearing under "Other commands" in
stripe --help.Root cause:
When the CLI starts up,
resources_gen.goauto-generates an apps resource command and setsrootCmd.Annotations["apps"] = "namespace".RemoveAppsCmdthen deletes the cobra command to cede the namespace to the apps plugin, but never cleaned up the annotation.The help template's "Other commands" section filters out any command with an entry in
rootCmd.Annotations:So the hint command added by
AddHintCommandswas registered and runnable (stripe apps worked) but invisible in --help due to the stale annotation.This is safe — the annotation's only consumers (the help template and
showInResources) both operate on the apps command, which is already removed.Test:
Running

stripe --helpBefore:
After:
