Add invoice.upcoming trigger support via test clock fixture#1582
Open
SumitKumar-17 wants to merge 1 commit into
Open
Add invoice.upcoming trigger support via test clock fixture#1582SumitKumar-17 wants to merge 1 commit into
SumitKumar-17 wants to merge 1 commit into
Conversation
|
|
1 similar comment
|
|
Author
|
If Approved adds the invoice.upcoming triggers also fixes #558 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @
cc @stripe/developer-products
Summary
Fixes the issue where
stripe trigger invoice.upcomingfailedwith "event is not supported", even though
stripe listen --events invoice.upcomingalready worked.
Root cause:
invoice.upcomingis a system-generated event fired byStripe's billing engine 3 days before a subscription renews.
Fix: Add
pkg/fixtures/triggers/invoice.upcoming.jsonusing Stripe'stest clock API — the approach Stripe's own documentation recommends for
testing time-based billing events.
The fixture:
pm_card_visaas default payment method)which causes Stripe's billing engine to emit
invoice.upcomingUsing static timestamps keeps the fixture deterministic.
Verified end-to-end against live test keys:
Stripe returned
evt_...with"type": "invoice.upcoming","billing_reason": "upcoming", and a draft invoice (no ID) attached —exactly the payload a real
invoice.upcomingwebhook carries.Changes
pkg/fixtures/triggers/invoice.upcoming.json— new fixture file