Embed commit SHA in dev builds and skip update check for non-release …#1571
Draft
vcheung-stripe wants to merge 1 commit into
Draft
Embed commit SHA in dev builds and skip update check for non-release …#1571vcheung-stripe wants to merge 1 commit into
vcheung-stripe wants to merge 1 commit into
Conversation
vcheung-stripe
force-pushed
the
vcheung-sha-version
branch
from
6722398 to
6c3cec4
Compare
Collaborator
Author
|
Example: 
When the working tree is dirty, we still show master: 
|
…versions `make build` now injects the short git SHA via ldflags when the working tree is clean, matching how GoReleaser sets the version for releases. CheckLatestVersion skips the GitHub API check unless the version parses as a valid semver (i.e. a real release), so SHA and "master" builds are unaffected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
vcheung-stripe
force-pushed
the
vcheung-sha-version
branch
from
6c3cec4 to
6d05d13
Compare
Collaborator
Author
|
TODO: This breaks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…versions
make buildnow injects the git SHA via ldflags when the working tree is clean, matching how GoReleaser sets the version for releases. CheckLatestVersion skips the GitHub API check unless the version parses as a valid semver (i.e. a real release), so SHA and "master" builds are unaffected.Committed-By-Agent: claude
Reviewers
r? @
cc @stripe/developer-products
Summary