Fix: recreate dependent views when altering column type #270
Open
feelixs wants to merge 2 commits intostripe:mainfrom
Open
Fix: recreate dependent views when altering column type #270feelixs wants to merge 2 commits intostripe:mainfrom
feelixs wants to merge 2 commits intostripe:mainfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
buildViewDiff, after checking for deleted columns, also check if any dependent column's type is being altered. If so, mark the view for recreation (drop before, recreate after).Motivation
When a table column's type is changed, views that depend on it are not dropped first and recreated later, causing ALTER TABLE...ALTER COLUMN...SET DATA TYPE to fail:
Error: 0A000: cannot alter type of a column used by a view or ruleTesting
Added three acceptance test cases in
view_cases_test.go:Without the fix, the first two tests fail with the Postgres error above.