Fix window creation logic

[strickvl]

Summary

• fix create_windows so overlap size of zero doesn't exit loop early

Testing

• python -m py_compile $(git ls-files '*.py')
• pytest -q (fails: command not found)

Summary by Sourcery

Remove debug logging and streamline the sliding-window logic in create_windows to prevent premature termination when overlap_size is zero

Bug Fixes:

• Prevent create_windows from exiting early when overlap_size is zero by adjusting the start position update

Enhancements:

• Remove debug print statements from create_windows

[sourcery-ai]

Reviewer's Guide

Refactors create_windows by removing debug prints and simplifying the start position update to correctly handle zero overlap without premature loop termination.

File-Level Changes

Change	Details	Files
Removed debug print statements from create_windows	Deleted initial debug prints for text, window size, and overlap size Removed per-window creation print Removed final summary print of window count	src/tinbox/core/translation/algorithms.py
Simplified start position update logic for overlapping windows	Replaced start = end - min(overlap_size, end - start) with start = end - overlap_size Removed conditional break checks for start <= 0 or start >= end Added a concise comment explaining movement to the next window	src/tinbox/core/translation/algorithms.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @strickvl - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

• Reintroduce clamp or break to prevent invalid or duplicate windows (link)

Here's what I looked at during the review

• 🔴 General issues: 1 blocking issue, 1 other issue
• 🟢 Testing: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion (bug_risk): Reintroduce clamp or break to prevent invalid or duplicate windows

Clamp start (e.g. start = max(0, end - overlap_size)) and reintroduce a break if start <= prev_start or start <= 0 to avoid invalid windows or infinite loops.

[sourcery-ai]

suggestion (bug_risk): Validate overlap_size against window_size

When overlap_size >= window_size, the loop won’t advance or produce windows. Consider raising an error or normalizing overlap_size up front, e.g.: overlap_size = min(overlap_size, window_size - 1).

Suggested change

	if not text:
	return []
	if overlap_size >= window_size:
	overlap_size = min(overlap_size, window_size - 1)
	if not text:
	return []