Conversation
- Add new docs/user-guide/concepts/plugins/index.md with comprehensive plugin documentation covering overview, basic usage, creating custom plugins, async initialization, advanced patterns, and best practices - Update mkdocs.yml navigation to include Plugins under Concepts - Update docs/community/get-featured.md to add Plugins category type - Update docs/user-guide/concepts/agents/hooks.md with: - Plugin recommendation tip at the top - Simplified agent.add_hook() API with type inference documentation - HookProvider vs Plugin comparison note - Add plugin recommendation tips to guardrails.md and retry-strategies.md - Update AGENTS.md directory structure to include plugins directory Resolves #568
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Assessment: Request Changes This PR adds comprehensive documentation for the Plugins feature. The documentation is well-structured with good use of diagrams, code examples, and cross-references. However, there are two issues that need attention before merging. Review Summary
The overall documentation quality is excellent - the plugins concept is clearly explained with practical examples and good guidance on when to use plugins vs hooks. 👍 |
Documentation Deployment CompleteYour documentation preview has been successfully deployed! Preview URL: https://d3ehv1nix5p99z.cloudfront.net/pr-573/ |
|
/strands can you update the docs to include the changes in this pull request: strands-agents/sdk-python#1739 |
Update plugins documentation to include: - @hook decorator for declarative hook registration - Event type inference from type hints - Union types for multiple event handlers - Auto-discovery of @tool decorated methods in plugins - Updated examples showing declarative approach - Guidance on when to use @hook vs manual registration - Multiple agents with same plugin instance pattern References strands-agents/sdk-python#1739
|
Assessment: Request Changes The documentation has been significantly improved with the addition of Remaining Issue
Once this file is removed, the PR should be ready to merge. The documentation is comprehensive and well-organized. 👍 |
|
Assessment: Request Changes (No changes since last review) The To remove it: git rm build_output.log
git commit -m "chore: remove accidentally committed build output"
git pushThe documentation content itself is ready to merge once this file is removed. |
Documentation Deployment CompleteYour documentation preview has been successfully deployed! Preview URL: https://d3ehv1nix5p99z.cloudfront.net/pr-573/ |
# Conflicts: # AGENTS.md # docs/user-guide/concepts/agents/hooks.md # mkdocs.yml
There was a problem hiding this comment.
Assessment: Comment (Minor Issues)
The PR has been successfully updated with the MDX conversion and new navigation format. The merge with main has been completed.
Changes Verified
- ✅ Converted to MDX format with
<Tabs>and<Tab>components - ✅ Navigation updated in
src/config/navigation.yml - ✅ Plugins documentation preserved (270 lines)
- ✅ hooks.mdx updated with "Using Plugins for Multiple Hooks" section
- ✅ get-featured.mdx updated with Plugins category
Minor Issues
⚠️ Some internal links still use.mdextension (lines 5, 11, 189, 228, 268-269) while files are now.mdx- Verify if the docs system automatically resolves these or if they need updating
The content is solid - just need to confirm the link handling. Otherwise ready to merge! 🚀
Documentation Preview ReadyYour documentation preview has been successfully deployed! Preview URL: https://d3ehv1nix5p99z.cloudfront.net/pr-cms-573/docs/user-guide/quickstart/overview/ Updated at: 2026-03-10T14:02:47.189Z |
There was a problem hiding this comment.
Assessment: Comment (One Minor Fix Remaining)
Most links have been fixed in commit 84c0362. Good progress!
Fixed Links
- ✅ Line 189:
[Agent State](../agents/state.mdx) - ✅ Line 268:
[Hooks](../agents/hooks.mdx) - ✅ Line 269:
[Steering](../experimental/steering.mdx)
Remaining Issue
⚠️ Line 5:[steering](../experimental/steering.md)- still uses.md
Once this last link is fixed, the PR is ready to merge! 🚀
There was a problem hiding this comment.
Assessment: Comment (One Minor Fix Still Remaining)
Commit c71a850 updated the content structure but the .md link on line 5 still needs to be fixed.
Link Status
| Line | Link | Status |
|---|---|---|
| 5 | [steering](../experimental/steering.md) |
.md |
| 9 | [Steering](../experimental/steering) |
✅ No extension |
| 266 | [Hooks](../agents/hooks.mdx) |
✅ Fixed |
| 267 | [Steering](../experimental/steering.mdx) |
✅ Fixed |
Once line 5 is updated, the PR is ready to merge! 🚀
7 participants
Summary
This PR adds comprehensive documentation for Plugins, a new composable mechanism for extending agent functionality in the Strands SDK.
Changes
New Documentation
docs/user-guide/concepts/plugins/index.md: Comprehensive plugin documentation covering:Agent(plugins=[...])@hookdecorator for declarative hook registration with event type inference@hookand@tooldecorated methodsPluginbase classNavigation Updates
mkdocs.ymlRelated Documentation Updates
docs/community/get-featured.md: Added Plugins as a new category type for community contributionsdocs/user-guide/concepts/agents/hooks.md:agent.add_hook()API with type hint inferencedocs/user-guide/safety-security/guardrails.md: Added tip about packaging guardrails as pluginsdocs/user-guide/concepts/agents/retry-strategies.md: Added tip about packaging retry logic as pluginsAGENTS.md: Updated directory structure to include the new plugins directoryTechnical Notes
{{ ts_not_supported_code() }}macros@hookdecorator feature from [FEATURE] Create@hookdecorator for Plugins sdk-python#1739Resolves #568