experiment: hide the names of blocked users that reacted to a message#1074
Draft
amycatgirl wants to merge 1 commit intostoatchat:mainfrom
Draft
experiment: hide the names of blocked users that reacted to a message#1074amycatgirl wants to merge 1 commit intostoatchat:mainfrom
amycatgirl wants to merge 1 commit intostoatchat:mainfrom
Conversation
This is an experimental feature. I don't really know what would the best approach be to hide reactions from blocked users, since using the set's difference seems to completely break solidjs reactivity. Feedback welcome :) Signed-off-by: Amy <amy+git@amogus.cloud>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experimental feature that hides the name of blocked users inside reactions.
Originally, this feature was supposed to hide the reaction itself, instead of just hiding the name of the person who reacted, however, I don't really know what would the best approach to do this would be. Since using the difference of a set seems to completely break solid.js reactivity, even when wrapping the set in a deferred or memorized signal.
I am open to any other ideas to fix this problem, as well as feedback regarding the feature (ie. whether it should be a toggle in settings).