fix: Make the sync store only update if remote is different than local#1031
Open
Dadadah wants to merge 1 commit intostoatchat:mainfrom
Open
fix: Make the sync store only update if remote is different than local#1031Dadadah wants to merge 1 commit intostoatchat:mainfrom
Dadadah wants to merge 1 commit intostoatchat:mainfrom
Conversation
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
chrishultin
approved these changes
Mar 15, 2026
mihaicm93
approved these changes
Mar 20, 2026
insertish
reviewed
Mar 21, 2026
Contributor
insertish
left a comment
insertish
left a comment
There was a problem hiding this comment.
Maybe instead of writing out our own comparison functions, we just use lodash isEqual?
Member
Author
|
I'm not sure we can use isEqual when using states like this. The state doesn't return a pure object so it won't be equal with the parsed object. Is there a way to get the pure object out of the state? Edit: Alternatively, should I write a method to get the pure object out of the state for comparison with isEquals? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a deep equal function to Ordering and NotificationOptions stores. The sync store will not attempt to update the server if the incoming data is equal to the existing data.
Closes #1009