Merged
Conversation
Its-Alex
force-pushed
the
itsalex-use-upstream-pg-back
branch
from
20d5f45 to
d899333
Compare
Owner
|
@Its-Alex For now, I've only taken a quick look. It looks good to me. Let me know as soon as you've tested it and finished. |
Its-Alex
force-pushed
the
itsalex-use-upstream-pg-back
branch
from
d899333 to
5692f51
Compare
There was a problem hiding this comment.
Pull Request Overview
Replaces the custom pg_back fork with the official upstream repository and updates all Docker image tags, CI workflows, and configuration keys to reflect the change.
- Switch Docker build/run instructions and CI workflows to use
stephaneklein/pg_back-docker-sidecar(no:sklein-forksuffix) and tag images by upstream commit - Modify
Dockerfileto clone and build from the officialpg_backrepo at a specific commit - Rename the config template key
uniform_snapshot_timestamptouniform_timestampand update related docs
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/README.md | Removed :sklein-fork suffix from Docker commands |
| scripts/docker-push.sh | Pushing :latest instead of :sklein-fork |
| pg_back.conf.tmpl | Renamed uniform_snapshot_timestamp to uniform_timestamp |
| docker-compose.yml | Updated service images to use the new sidecar tag |
| README.md | Updated production example to refer to the official sidecar image |
| Dockerfile | Cloning/updating to upstream pg_back at a specific commit |
| .github/workflows/docker-test.yml | Adjusted docker_tag suffix to include pg_back commit identifier |
| .github/workflows/docker-publish.yml | Same tag update as in test workflow |
Comments suppressed due to low confidence (2)
pg_back.conf.tmpl:50
- Renaming the configuration key
uniform_snapshot_timestamptouniform_timestampmay break existing user configurations. Consider adding a deprecation note or updating documentation to highlight this change and guide users to the new key.
uniform_timestamp = true
.github/workflows/docker-test.yml:22
- [nitpick] The tag suffix
pg_back5375ec2may be unclear without a separator. Consider using a hyphen (e.g.,-pg_back-5375ec2) or adopting semantic versioning for better readability.
echo "docker_tag=${DATETIME}-${SHORT_SHA}-pg_back5375ec2" >> $GITHUB_OUTPUT
Collaborator
Author
I've made all the tests locally, it's working 👍 |
| uniform_snapshot_timestamp = true | ||
| # Apply the same consistent timestamp to all filenames generated | ||
| # by pg_back instead of using individual file creation times | ||
| uniform_timestamp = true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that orgrim/pg_back#147 (comment) has been merged, the pg_back fork used in the repository is no longer relevant.
The purpose of this merge request is to replace the fork with the upstream version.