Various fixes, part 5 by quietbits · Pull Request #963 · stellar/js-stellar-base

quietbits · 2026-04-02T15:05:48Z

Medium items 6-10 from the doc.

…base into some-fixes-4

…base into some-fixes-5

github-actions · 2026-04-02T15:07:10Z

Size Change: +4.36 kB (+0.25%)

Total Size: 1.76 MB

📦 View Changed

Filename	Size	Change
`dist/stellar-base.cjs.js`	699 kB	+1.68 kB (+0.24%)
`dist/stellar-base.js`	718 kB	+1.73 kB (+0.24%)
`dist/stellar-base.min.js`	346 kB	+951 B (+0.28%)

_{compressed-size-action}

quietbits · 2026-04-02T15:08:25Z

src/transaction_builder.ts

-      console.log("minAccountSequenceAge", tx.minAccountSequenceAge);
-      console.log(
-        "builderOpts.minAccountSequenceAge",
-        builderOpts.minAccountSequenceAge,
-      );


I removed these console.log. We can put them back if needed.

Copilot

Pull request overview

This PR adds more runtime validation and round-trip robustness across transaction building and operation helpers, plus improves integer auto-sizing edge cases for Soroban ScInt.

Changes:

Add constructor-time validation for timebounds and ledgerbounds in TransactionBuilder (and corresponding unit tests).
Improve Operation.manageData and Operation.changeTrust round-tripping through fromXDRObject by accepting shapes produced by parsing XDR (and add tests).
Adjust ScInt type auto-selection logic for negative boundary values and add boundary-focused tests.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
test/unit/transaction_builder.test.ts	Adds tests for constructor validation of timebounds/ledgerbounds.
test/unit/operations/manage_data.test.ts	Adds round-trip test for delete (`null`/missing) manageData value.
test/unit/operations/change_trust.test.ts	Adds round-trip tests for Asset and LiquidityPoolAsset changeTrust parsing/rebuild.
test/unit/numbers/sc_int.test.ts	Adds tests for exact signed minimum boundaries for i64/i128/i256.
src/transaction_builder.ts	Implements constructor-time validation and introduces `toEpochSeconds` helper.
src/operations/manage_data.ts	Accepts `undefined` as delete semantics (treated as `null`).
src/operations/change_trust.ts	Accepts `line` as an alias for `asset` for round-trip compatibility.
src/numbers/sc_int.ts	Changes negative bit-length sizing logic for `ScInt` auto-selection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/numbers/sc_int.ts

src/transaction_builder.ts

Copilot · 2026-04-02T15:15:02Z

src/operations/manage_data.ts

@@ -32,7 +33,7 @@ export function manageData(
  if (typeof opts.value === "string") {
    dataValue = Buffer.from(opts.value);
  } else {
-    dataValue = opts.value;
+    dataValue = opts.value ?? null;
  }


This change makes manageData treat value: undefined as a delete (null), which helps round-tripping Operation.fromXDRObject results (where value is optional). However, the thrown message still says "string, Buffer or null" and the public ManageDataOpts type currently requires value: Buffer | string | null (no undefined). Consider updating the error text and aligning the TypeScript types/docs with the new accepted input (e.g. make value optional or include undefined).

This is intentional — undefined is only accepted as an internal tolerance for XDR round-trips (fromXDRObject returns undefined for absent optional fields). The public API contract remains null for delete-entry, so the error message and ManageDataOpts type are kept as-is to avoid confusing users with an implementation detail they shouldn't need to know about.

Copilot · 2026-04-02T15:15:03Z

src/operations/change_trust.ts

+  // Accept `line` as an alias for `asset` so that the output of
+  // fromXDRObject (which uses `line`) can round-trip back through here.
+  const asset =
+    opts.asset ??
+    (opts as unknown as { line?: Asset | LiquidityPoolAsset }).line;
  let line: xdr.ChangeTrustAsset;

-  if (opts.asset instanceof Asset) {
-    line = opts.asset.toChangeTrustXDRObject();
-  } else if (opts.asset instanceof LiquidityPoolAsset) {
-    line = opts.asset.toXDRObject();
+  if (asset instanceof Asset) {
+    line = asset.toChangeTrustXDRObject();
+  } else if (asset instanceof LiquidityPoolAsset) {
+    line = asset.toXDRObject();
  } else {
    throw new TypeError("asset must be Asset or LiquidityPoolAsset");
  }


changeTrust now accepts line as an alias for asset to support round-tripping fromXDRObject results, but the public ChangeTrustOpts type still requires asset and does not include line. Consider updating the exported typings (and optionally docs) to reflect that callers may pass line (or change the record shape) so the round-trip pattern is supported without casts.

Same approach as the manageData case — line is only produced internally by fromXDRObject. The public API contract remains asset. Changing ChangeTrustOpts to expose line would either make asset optional (breaking) or require a union type that adds complexity for an internal concern. The cast is intentional and the comment explains why.

Ryang-21 · 2026-04-02T16:29:33Z

test/unit/operations/change_trust.test.ts

+
+    // parsed has `line` (not `asset`); changeTrust accepts both
+    const rebuilt = Operation.changeTrust(parsed);
+    expect(rebuilt).toBeInstanceOf(xdr.Operation);


we should check that the rebuilt and the original op are the same. An easy way to do this would be string comparing the xdr strings of the two

Ryang-21 · 2026-04-02T16:31:31Z

test/unit/operations/manage_data.test.ts

+      name: parsed.name,
+      value: parsed.value,
+    });
+    expect(rebuilt).toBeInstanceOf(xdr.Operation);


ditto here we should check that they are the same operation

quietbits added 22 commits March 31, 2026 14:05

util/continued_fraction updated

00b4cfc

muxed_account updated

552f6eb

Added operation test

ad22db8

Add immutable tx flag

06d451d

auth updated

6904d28

scval updated

eb6ce90

Added source acc test for getClaimableBalanceId()

4df96f1

Copilot feedback

0d3750e

operation + revoke_sponsorship updated

be74640

transaction_builder updated

b9744b3

soroban updated

d2ec4ba

Fix locale-dependent map key sorting in scvSortedMap and nativeToScVal

c8d6495

Reject non-boolean trustline flag values in setTrustLineFlags

008caed

Copilot feedback

3250551

Fix negative BigInt bit-length off-by-one in ScInt type auto-selection

e4ed91e

Always return immutable tx, remove opt-in immutableTx flag

b2fca1d

Merge branch 'some-fixes-3' of https://github.com/stellar/js-stellar-…

268a91d

…base into some-fixes-4

Merge branch 'some-fixes-4' of https://github.com/stellar/js-stellar-…

b1a78bf

…base into some-fixes-5

Validate timebounds/ledgerbounds in TransactionBuilder constructor

0eab134

Accept undefined as delete-entry value in manageData

f7fb823

Accept line as alias for asset in changeTrust builder

d32b8df

Review cleanup

c6e8f0e

quietbits commented Apr 2, 2026

View reviewed changes

quietbits requested a review from Copilot April 2, 2026 15:08

Copilot started reviewing on behalf of quietbits April 2, 2026 15:09 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

Copilot feedback

9d92c67

quietbits requested a review from Ryang-21 April 2, 2026 15:44

Ryang-21 reviewed Apr 2, 2026

View reviewed changes

Ryang-21 approved these changes Apr 2, 2026

View reviewed changes

Add tests for op check

c70ca5c

Base automatically changed from some-fixes-4 to typescript-migration April 2, 2026 20:16

quietbits added 2 commits April 2, 2026 16:19

Resolved merge conflicts

dd57f2f

Updated changelog

0e5828a

quietbits merged commit 44288b1 into typescript-migration Apr 2, 2026
7 checks passed

quietbits deleted the some-fixes-5 branch April 2, 2026 20:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various fixes, part 5#963

Various fixes, part 5#963
quietbits merged 26 commits intotypescript-migrationfrom
some-fixes-5

quietbits commented Apr 2, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

quietbits Apr 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

quietbits Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

quietbits Apr 2, 2026

Uh oh!

Ryang-21 Apr 2, 2026

Uh oh!

Ryang-21 Apr 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

quietbits commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

quietbits Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

quietbits Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

quietbits Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Ryang-21 Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Ryang-21 Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

quietbits commented Apr 2, 2026 •

edited

Loading

github-actions bot commented Apr 2, 2026 •

edited

Loading