Merged
Conversation
|
Size Change: +3.6 kB (+0.21%) Total Size: 1.76 MB 📦 View Changed
|
There was a problem hiding this comment.
Pull request overview
Extends SDK behavior and tests to handle additional edge cases around Soroban formatting, SCVal map ordering, muxed-account destinations in SAC transfers, and signer-key support for revoke sponsorship.
Changes:
- Allow
addSacTransferOperationto accept muxed (M...) destinations by extracting the base (G...) address for ledger key construction. - Fix
Soroban.formatTokenAmountfor negative values that require zero-padding, and make SCVal map sorting deterministic (codepoint/byte-like order). - Add stricter runtime validation for
setTrustLineFlagsflag values and added25519SignedPayloadsupport for revoke-signer sponsorship (create + deserialize).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/transaction_builder.ts |
Uses extractBaseAddress so muxed destinations can be used for footprint ledger keys. |
src/soroban.ts |
Preserves/returns negative sign correctly when formatting token amounts. |
src/scval.ts |
Replaces localeCompare with deterministic string ordering for map sorting. |
src/operations/set_trustline_flags.ts |
Enforces that provided flag values are boolean (or undefined). |
src/operations/revoke_sponsorship.ts |
Adds support for ed25519SignedPayload signer keys. |
src/operations/types.ts |
Extends RevokeSignerOpts to include Ed25519SignedPayloadSignerOpt. |
src/operation.ts |
Adds decoding support for signerKeyTypeEd25519SignedPayload. |
test/unit/transaction_builder.test.ts |
Adds muxed-destination tests for SAC transfers. |
test/unit/soroban.test.ts |
Adds negative-amount zero-padding coverage. |
test/unit/scval.test.ts |
Adds coverage ensuring deterministic mixed-case key ordering. |
test/unit/operations/set_trustline_flags.test.ts |
Adds coverage for rejecting non-boolean flag values. |
test/unit/operations/revoke_sponsorship.test.ts |
Adds coverage for signed-payload signer create + deserialize. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ryang-21
reviewed
Apr 2, 2026
|
|
||
| export type RevokeSignerOpts = | ||
| | Ed25519PublicKeySignerOpt | ||
| | Ed25519SignedPayloadSignerOpt |
Contributor
There was a problem hiding this comment.
Nice catch I assumed revoke sponsor did not apply for signed payloads
Ryang-21
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Medium items 1-5 from the doc.