Skip to content

Add unit test locking in tx getter defensive-copy immutability #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sagpatil merged 3 commits into from
Mar 17, 2026
Merged

Add unit test locking in tx getter defensive-copy immutability #941

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
396ed8f
Initial plan
Copilot Mar 17, 2026
569185f
Add unit test for tx getter defensive copy behavior
Copilot Mar 17, 2026
fb4361b
Rename variable t to txCopy for clarity in tx getter test
Copilot Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions test/unit/transaction_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,13 @@ describe('Transaction', function () {
const envelope = transaction.toEnvelope().value();
envelope.tx().fee(StellarBase.xdr.Int64.fromString('300'));

expect(transaction.tx.fee().toString()).to.equal('100');
});
it('tx getter returns a defensive copy that does not affect internal XDR', function () {
const transaction = this.transaction;
const txCopy = transaction.tx;
txCopy.fee(StellarBase.xdr.Int64.fromString('999'));

expect(transaction.tx.fee().toString()).to.equal('100');
});
});
Expand Down
Loading