Skip to content

Add negative test coverage for memo ID scientific notation and trailing decimal zero #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sagpatil merged 2 commits into from
Mar 17, 2026
Merged

Add negative test coverage for memo ID scientific notation and trailing decimal zero #940

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b1937d
Initial plan
Copilot Mar 17, 2026
79a1988
Add negative test cases for memo ID scientific notation and trailing …
Copilot Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/unit/memo_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@ describe('Memo.id()', function () {
expect(() => StellarBase.Memo.id('-1')).to.throw(/Expects a uint64/);
// decimal
expect(() => StellarBase.Memo.id('1.5')).to.throw(/Expects a uint64/);
// trailing decimal zero (BigNumber accepts but must be rejected)
expect(() => StellarBase.Memo.id('1.0')).to.throw(/Expects a uint64/);
// scientific notation (BigNumber accepts but BigInt()/UnsignedHyper crashes)
expect(() => StellarBase.Memo.id('1e18')).to.throw(/Expects a uint64/);
// overflow: 2^64 silently became 0 before this fix
expect(() => StellarBase.Memo.id('18446744073709551616')).to.throw(
/Expects a uint64/
Expand Down
Loading