Update PropertyOutput.m_MemberIsProperty from Inspector#13
Open
shivaduke28 wants to merge 1 commit intostella3d:mainfrom
Open
Update PropertyOutput.m_MemberIsProperty from Inspector#13shivaduke28 wants to merge 1 commit intostella3d:mainfrom
PropertyOutput.m_MemberIsProperty from Inspector#13shivaduke28 wants to merge 1 commit intostella3d:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I am a VRChat user and just recently started using this library. It is very useful, thank you.
I made a PR because I thought the
PropertyOutputcomponent was not working correctly. I am new to OSC and this library so I apologize if I have misunderstood something.Although
m_MemberIsPropertyis used to determine whether to be usedPropertyorField, its value is set only in the setter of them, resulting in it seems alwaysfalse. This makesPropertyOutputnot work whenLight.intensityis used for example.I have made changes to Inspector to fix this.