Fix OAuth client credentials and gzip decoding#27
Open
petersentaylor wants to merge 1 commit intosteipete:mainfrom
Open
Fix OAuth client credentials and gzip decoding#27petersentaylor wants to merge 1 commit intosteipete:mainfrom
petersentaylor wants to merge 1 commit intosteipete:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept-Encoding: gzipso Go can transparently decode API responsesWhy
The current auth flow sends a hardcoded
sleep-clientpayload with an empty client secret, which causes the OAuth token endpoint to fail and forces the CLI onto the legacy login fallback. In practice that fallback can get rate-limited with429 Too Many Requests.After fixing the OAuth request, live status requests succeeded, but response decoding still failed because the client explicitly requested gzip and then attempted to JSON-decode compressed bytes directly. Removing the manual
Accept-Encodingheader lets Go handle decompression correctly.Verification
go test ./...eightctl statuson macOS after rebuilding the binary