Show tertiary usage rows in widget#1160
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed May 26, 2026, 5:04 AM ET / 09:04 UTC. Summary Reproducibility: yes. source inspection gives a high-confidence reproduction path: current main builds only primary and secondary rows for non-Codex widget snapshots and legacy fallback entries, while Antigravity exposes a supported Gemini Flash tertiary lane. A focused Antigravity UsageSnapshot or ProviderEntry with tertiary data would reproduce the omission without launching the app. Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance: Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge Security Review detailsBest possible solution: Land the narrow widget row-generation change after the contributor adds real widget proof and focused test validation is confirmed by CI or a full Xcode environment. Do we have a high-confidence way to reproduce the issue? Yes, source inspection gives a high-confidence reproduction path: current main builds only primary and secondary rows for non-Codex widget snapshots and legacy fallback entries, while Antigravity exposes a supported Gemini Flash tertiary lane. A focused Antigravity UsageSnapshot or ProviderEntry with tertiary data would reproduce the omission without launching the app. Is this the best way to solve the issue? Yes, the proposed code path is the narrow maintainable fix: add the metadata-gated tertiary row in both widget row builders and cover generated plus legacy widget data. It still needs real widget proof and focused test confirmation before merge. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against bba645336d3c. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
Testing
swift build --target CodexBarWidgetswift test --filter 'UsageStoreWidgetSnapshotTests|CodexBarWidgetProviderTests'could not run in this local Command Line Tools environment becauseKeyboardShortcutsfails to compile its SwiftUI#Previewmacros without XcodePreviewsMacros.