Display: add workday segmentation for weekly progress bars#1102
Display: add workday segmentation for weekly progress bars#1102Yuxin-Qiao wants to merge 3 commits into
Conversation
Fixes steipete#1096 — Weekly Progress Bar configurable to segment in number of work days. - Add a Display preference for weekly progress work-day segmentation: Off / 4 days / 5 days / 7 days - Draw display-only day-boundary tick marks on weekly usage bars - Keep the default Off / nil so existing users see no UI change - Merge work-day markers with existing quota warning markers - No warning/alert behavior added; future warnings remain out of scope for this PR Validation: - swift test --filter MenuCardQuotaWarningMarkerTests - swift test --filter SettingsStoreCoverageTests - swift test --filter MenuCardModelTests - make check
|
Codex review: needs real behavior proof before merge. Latest ClawSweeper review: 2026-05-22 17:27 UTC / May 22, 2026, 1:27 PM ET. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: not applicable. for a feature PR. Source review verifies the new display, settings, and model paths, but there is no current-main bug reproduction path to establish. PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge Security Review detailsBest possible solution: Land the opt-in setting after redacted UI proof shows Off and a segmented weekly bar in the built app, while keeping the default disabled for existing users. Do we have a high-confidence way to reproduce the issue? Not applicable for a feature PR. Source review verifies the new display, settings, and model paths, but there is no current-main bug reproduction path to establish. Is this the best way to solve the issue? Mostly yes if maintainers want this UI option: the patch keeps the default Off, reuses existing marker rendering, wires menu observation, and covers model/settings behavior, but it is not merge-ready without real UI proof. Label justifications:
What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against cdb6acba6407. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 472f90d1d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| warningMarkerPercents: (Self.warningMarkerPercents( | ||
| thresholds: input.quotaWarningThresholds[.weekly], | ||
| showUsed: input.usageBarsShowUsed)) | ||
| showUsed: input.usageBarsShowUsed) + workDayMarkerPercents( | ||
| workDays: input.workDaysPerWeek, | ||
| windowMinutes: weekly.windowMinutes)).sorted()) |
There was a problem hiding this comment.
The new work-day segmentation is only merged into secondaryMetric, so it affects non-Codex providers but not the Codex path that builds weekly bars via codexRateMetrics. When provider == .codex and a projection is present, users can set “Weekly progress work days” and see no day-boundary markers on the weekly lane, which makes the new Display setting inconsistent across providers. Please also merge workDayMarkerPercents(...) into the weekly case in codexRateMetrics.
Useful? React with 👍 / 👎.
clawsweeper
Bot
added
rating: 🧂 unranked krab
|
ClawSweeper PR egg 🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat. Where did the egg go?
|
|
Follow-up fixes pushed for review feedback:
Validation:
|
clawsweeper
Bot
added
the
P2
|
Status update:
I can also add a redacted screenshot or short recording showing the Display picker and weekly tick marks if that would help review. |
|
Pushed follow-up fix in ebf2e2f to unblock Linux CLI CI:\n\n- Added conditional import in for Linux symbol availability.\n- No behavior change to the weekly progress workday segmentation feature in this PR.\n\nI’ll also add UI proof (Display picker + weekly tick marks) next if needed for ClawSweeper proof gate. |
|
Follow-up fix pushed in
If needed, I can also attach UI proof (Display picker + weekly tick marks) for the ClawSweeper proof gate. |
1 participant
Fixes
Fixes #1096 — Weekly Progress Bar configurable to segment in number of work days.
Summary
UsageProgressBarmarker renderingScope
Validation
swift test --filter MenuCardQuotaWarningMarkerTestsswift test --filter SettingsStoreCoverageTestsswift test --filter MenuCardModelTestsmake checkgit diff --check