Add Münchner Stadtbibliothek (only SZ via munzinger.de)#399
Open
Strubbl wants to merge 3 commits intostefanw:mainfrom
Open
Add Münchner Stadtbibliothek (only SZ via munzinger.de)#399Strubbl wants to merge 3 commits intostefanw:mainfrom
Strubbl wants to merge 3 commits intostefanw:mainfrom
Conversation
This change is necessary in order to work for Münchner Stadtbibliothek to fetch SZ articles.
Strubbl
changed the title
Author
|
Thanks to @darkdragon-001 for the initial start in PR 184. I reused the portalId which saved me some time. |
This was referenced Mar 16, 2024
Contributor
|
FYI I added support via Genios in #442. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes #184.
I am not sure about the change from hardcoded Spiegel to SZ in the munzinger search URL. Do you have any hint about how to implement this better? With a separate
Sources?The change in the extractor is done to really remove the quotes from the query parameter. This is done, because special chars are also removed and thus an exact search for the query does not reveal any results anymore.
I tested my changes successfully with the following URLs
fixes #110
fixes #186
fixes #250
fixes #313
closes #184