Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e17b548fd6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
.github/workflows/auto-assign.yml
Outdated
| pull_request: | ||
| types: [opened] |
There was a problem hiding this comment.
This workflow listens on pull_request, but for PRs opened from forks (including Dependabot) GitHub provides a read-only GITHUB_TOKEN, so the action cannot write assignees and those PRs stay unassigned. Because this job only calls an assignment action and does not execute PR code, switching the trigger to pull_request_target is the safe way to make auto-assignment work for external contributors as intended.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
Ajoute un workflow GitHub Actions pour auto-assigner automatiquement un utilisateur aux issues et pull requests à leur ouverture, afin de réduire le tri manuel (Closes #85).
Changes:
- Création du workflow
.github/workflows/auto-assign.yml. - Déclenchement sur
issues.openedetpull_request.opened. - Utilisation de
pozil/auto-assign-issuepour assignernedseb.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/auto-assign.yml
Outdated
| on: | ||
| issues: | ||
| types: [opened] | ||
| pull_request: |
There was a problem hiding this comment.
Sur l’événement pull_request, le GITHUB_TOKEN est en lecture seule pour les PRs provenant de forks (GitHub Actions ne permet pas d’écrire sur les issues/assignees dans ce cas). Du coup l’auto-assignation risque de ne pas fonctionner pour une partie des PRs. Si l’objectif est d’assigner aussi les PRs externes, envisage pull_request_target (et garde le workflow sans checkout/exécution de code du PR) ou documente explicitement que cela ne couvrira que les PRs du même repo.
| pull_request: | |
| pull_request_target: |
| pull-requests: write | ||
| steps: | ||
| - name: Auto-assign issue | ||
| uses: pozil/auto-assign-issue@v2 |
There was a problem hiding this comment.
Le ticket / description mentionne pozil/auto-assign-issue@v1, mais le workflow utilise @v2. Si v2 est volontaire, il faudrait mettre à jour la référence (issue/PR description) ou ajouter une note expliquant le choix pour éviter la confusion et faciliter la maintenance.
| jobs: | ||
| run: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| issues: write | ||
| pull-requests: write |
There was a problem hiding this comment.
Les autres workflows du repo déclarent généralement permissions au niveau racine du workflow (ex: build.yml/deploy.yml/links.yml). Mettre permissions au top-level ici améliorerait la cohérence et évite des surprises si de nouveaux jobs sont ajoutés plus tard (ils hériteraient des permissions attendues).
| jobs: | |
| run: | |
| runs-on: ubuntu-latest | |
| permissions: | |
| issues: write | |
| pull-requests: write | |
| permissions: | |
| issues: write | |
| pull-requests: write | |
| jobs: | |
| run: | |
| runs-on: ubuntu-latest |
|
Commentaire traité en de65fa1 : |
Summary
auto-assign.yml: assigne automatiquement @nedseb sur les issues et PRs ouvertesCloses #85
Test plan