chore: fix JavaScript lint errors (issue 12236)#12261
Conversation
- Fix JSDoc doctest in remark-run-javascript-examples index.js - Update return value comment to match actual output format - Ensure self-require is last in example code - Fix no-new-array lint error in svg canvas main.js - Replace new Array() with array literal and push() - Add unit tests for canvas render event argument passing Resolves stdlib-js#12236
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Ref: #12257 |
|
Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
This PR fixes JavaScript lint errors reported in issue #12236.\n\n## Changes\n\n1. Fixed JSDoc doctest in remark-run-javascript-examples/lib/index.js\n2. Fixed no-new-array lint error in svg/canvas/lib/main.js\n3. Added unit tests for canvas render event argument passing\n\nResolves #12236