Skip to content

chore: fix JavaScript lint errors (issue 12236)#12261

Closed
kings9527 wants to merge 1 commit into
stdlib-js:developfrom
kings9527:develop
Closed

chore: fix JavaScript lint errors (issue 12236)#12261
kings9527 wants to merge 1 commit into
stdlib-js:developfrom
kings9527:develop

Conversation

@kings9527
Copy link
Copy Markdown

This PR fixes JavaScript lint errors reported in issue #12236.\n\n## Changes\n\n1. Fixed JSDoc doctest in remark-run-javascript-examples/lib/index.js\n2. Fixed no-new-array lint error in svg/canvas/lib/main.js\n3. Added unit tests for canvas render event argument passing\n\nResolves #12236

- Fix JSDoc doctest in remark-run-javascript-examples index.js
  - Update return value comment to match actual output format
  - Ensure self-require is last in example code
- Fix no-new-array lint error in svg canvas main.js
  - Replace new Array() with array literal and push()
- Add unit tests for canvas render event argument passing

Resolves stdlib-js#12236
@kings9527 kings9527 requested a review from a team May 24, 2026 05:11
@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels May 24, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@kgryte
Copy link
Copy Markdown
Member

kgryte commented May 24, 2026

Ref: #12257

@kgryte kgryte added autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. and removed Needs Review A pull request which needs code review. labels May 24, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants