chore: fix JavaScript lint errors (issue #12222)#12226
Open
algojogacor wants to merge 1 commit into
Open
Conversation
Contributor
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an independent contribution. I am not affiliated with the hackathon or any competition.
Summary
Replaces
new Array()constructor calls with array literals and.push()in the@stdlib/blas/base/gasumtest file to comply with thestdlib/no-new-arrayESLint rule.Root Cause
The automated JavaScript linting workflow detected 4 instances where
new Array( 100 )andnew Array( 240 )were used instead of array literals with.push().Fix
x = new Array( 100 )withx = []and index-based assignmentx[ i ] = ...withx.push( ... ).x = new Array( 240 )withx = []and index-based assignmentx[ i ] = ...withx.push( ... ).x.lengthto the explicit array size to maintain correctness after switching from pre-allocated arrays.The same pattern was fixed in both test blocks (standard and accessor variants), resolving all 4 lint violations.
Testing
test/test.ndarray.js.Resolves #12222