fix(string): handle emoji modifiers in previous grapheme breaks#12215
Open
sjh9714 wants to merge 2 commits into
Open
fix(string): handle emoji modifiers in previous grapheme breaks#12215sjh9714 wants to merge 2 commits into
sjh9714 wants to merge 2 commits into
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
stdlib-bot
added
Needs Review
Contributor
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1092.
Description
This pull request:
prevGraphemeClusterBreak( '👉🏿' )returning no previous break inside a single emoji modifier sequence.prevGraphemeClusterBreakto skip UTF-16 low surrogate code units without recording a grapheme break or clearing the grapheme/emoji property caches.prevGraphemeClusterBreak( '🌷🐷', 2 ) === 1.Related Issues
This pull request has the following related issues:
prevGraphemeClusterBreakpackage #1092Questions
No.
Other
The filtered JavaScript lint command exits successfully, but reports existing warnings for Devanagari sample strings and synchronous fixture reads in this package's existing files.
I did not run the full repository-wide
make testsuite.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I used Codex to inspect the affected grapheme-break code path, add the regression test, make the small implementation change, and run the listed local verification commands.
Testing
NODE_PATH=./lib/node_modules node - <<'NODE' ...reproduced the issue before the fix:prev(👉🏿)= 1,next(👉🏿)= -1,prev(🌷🐷,2)= 1.make test-javascript TESTS_FILTER=".*/string/prev-grapheme-cluster-break/.*"failed before the fix withexpected: -1,actual: 1for the new regression test.make TESTS_FILTER=".*/string/prev-grapheme-cluster-break/.*" testmake TESTS_FILTER=".*/string/next-grapheme-cluster-break/.*" testmake lint-javascript SOURCES_FILTER=".*/string/prev-grapheme-cluster-break/.*" TESTS_FILTER=".*/string/prev-grapheme-cluster-break/.*" EXAMPLES_FILTER=".*/string/prev-grapheme-cluster-break/.*" BENCHMARKS_FILTER=".*/string/prev-grapheme-cluster-break/.*"git diff --checkmake init@stdlib-js/reviewers