Ideal and robust soliton distribution#119
Open
refugeesus wants to merge 4 commits intostatrs-dev:masterfrom
Open
Ideal and robust soliton distribution#119refugeesus wants to merge 4 commits intostatrs-dev:masterfrom
refugeesus wants to merge 4 commits intostatrs-dev:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello all.
I have added in an implementation for the ideal and robust soliton distributions which are required in ECC and coding method implementations I am working on. To my knowledge these are correctly implemented as the libraries I utilize them in function as expected in their tests.
There are likely methods which should be implemented for the purposes of this library which I have not completed, and if so, I would be happy to complete them so this can be merged appropriately. I hope this has been added in appropriately, as it is a bit of an odd implementation of discrete uniform distributions. If the structure should change it would be helpful to have some guidance for what is best.