blockifier: extract CallInfo::get_visited_storage_entries#14026
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Artifacts upload workflows: |
PR SummaryLow Risk Overview Adds Reviewed by Cursor Bugbot for commit 2160a0b. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2160a0b. Configure here.
| call_info.get_visited_storage_entries().chain(block_hash_entries) | ||
| }) | ||
| .collect() | ||
| } |
There was a problem hiding this comment.
New public method has no callers in codebase
Low Severity
TransactionExecutionInfo::get_visited_storage_entries is a newly added pub method with zero callers anywhere in the codebase. A grep for all usages of get_visited_storage_entries shows that the only call sites invoke the CallInfo method, not this TransactionExecutionInfo method. The associated imports (HashSet, BLOCK_HASH_TABLE_ADDRESS, StorageKey, StorageEntry) are also only needed for this unused function.
Reviewed by Cursor Bugbot for commit 2160a0b. Configure here.
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on yoavGrs).



Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com