Skip to content

blockifier: extract CallInfo::get_visited_storage_entries#14026

Open
yoavGrs wants to merge 1 commit into
mainfrom
refactor/call-info-visited-storage-entries
Open

blockifier: extract CallInfo::get_visited_storage_entries#14026
yoavGrs wants to merge 1 commit into
mainfrom
refactor/call-info-visited-storage-entries

Conversation

@yoavGrs
Copy link
Copy Markdown
Contributor

@yoavGrs yoavGrs commented May 14, 2026

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

yoavGrs commented May 14, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown

Artifacts upload workflows:

@yoavGrs yoavGrs self-assigned this May 14, 2026
@yoavGrs yoavGrs requested a review from ArielElp May 14, 2026 09:17
@yoavGrs yoavGrs marked this pull request as ready for review May 14, 2026 09:17
@cursor
Copy link
Copy Markdown

cursor Bot commented May 14, 2026

PR Summary

Low Risk
Low risk refactor/addition: it factors out visited storage entry iteration and adds a new accessor on TransactionExecutionInfo; the main risk is subtle mismatches in which storage keys (especially block-hash table reads) are included.

Overview
Refactors storage-key collection by extracting CallInfo::get_visited_storage_entries() and using it inside execution summarization instead of duplicating the mapping logic.

Adds TransactionExecutionInfo::get_visited_storage_entries() to return the full visited storage-entry set across all call infos, including extra entries for get_block_hash reads via (BLOCK_HASH_TABLE_ADDRESS, block_number).

Reviewed by Cursor Bugbot for commit 2160a0b. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2160a0b. Configure here.

call_info.get_visited_storage_entries().chain(block_hash_entries)
})
.collect()
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New public method has no callers in codebase

Low Severity

TransactionExecutionInfo::get_visited_storage_entries is a newly added pub method with zero callers anywhere in the codebase. A grep for all usages of get_visited_storage_entries shows that the only call sites invoke the CallInfo method, not this TransactionExecutionInfo method. The associated imports (HashSet, BLOCK_HASH_TABLE_ADDRESS, StorageKey, StorageEntry) are also only needed for this unused function.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2160a0b. Configure here.

Copy link
Copy Markdown
Contributor

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ArielElp reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on yoavGrs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants