apollo_gateway: skip archiving proof if transaction is P2P

[einat-starkware]

No description provided.

[einat-starkware]

• apollo_gateway: skip archiving proof if transaction is P2P #14022 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[cursor]

PR Summary

Medium Risk
Changes the proof archiving/forwarding flow so P2P-originated transactions no longer perform (or can fail due to) GCS proof writes, which could affect proof persistence/observability if the P2P flag is misclassified. Logic is localized but touches the transaction acceptance path and its error handling.

Overview
Gateway add_tx now detects whether a transaction arrived via P2P (p2p_message_metadata.is_some()) and passes this into store_proof_and_spawn_archiving.

For P2P transactions, the gateway skips spawning the async GCS proof archive write, while still storing the proof in the proof manager; archive-task abort handling is updated to account for the handle being optional.

Tests are updated to thread p2p_message_metadata through helpers, assert set_proof is only called for non-P2P, and expand the positive path to cover both P2P and non-P2P submissions (with mempool forwarding no longer gated by archive outcome on the P2P path).

^{Reviewed by Cursor Bugbot for commit aedeea7. Bugbot is set up for automated code reviews on this repo. Configure here.}

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

---

crates/apollo_gateway/src/gateway_test.rs line 567 at r1 (raw file):

    let expected_proof_archive_result: Result<(), ProofArchiveError> =
        Err(ProofArchiveError::WriteError("failed upload".to_string()));
    setup_mock_state(&mut mock_dependencies, &tx_args, Ok(()), expected_proof_archive_result, None)

name this arg before passing it

Code quote:

None)

[einat-starkware]

crates/apollo_gateway/src/gateway_test.rs line 567 at r1 (raw file):

Previously, AvivYossef-starkware wrote…

name this arg before passing it

Done