apollo_starknet_os_program: update cairo-lang to 0.14.3a1#14020
apollo_starknet_os_program: update cairo-lang to 0.14.3a1#14020dorimedini-starkware wants to merge 1 commit into
Conversation
PR SummaryMedium Risk Overview Refreshes Starknet OS artifacts for the new compiler: updates Aligns resource accounting with the new outputs by retuning Blake-based CASM hash step estimation constants and updating compiled-class-hash test expectations; removes the Reviewed by Cursor Bugbot for commit dcd17fb. Bugbot is set up for automated code reviews on this repo. Configure here. |
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status: 0 of 73 files reviewed, 1 unresolved discussion (waiting on Yoni-Starkware).
crates/apollo_infra_utils/src/cairo0_compiler.rs line 36 at r1 (raw file):
}) }) }
this and related changes are required because cairo-lang scripts (cairo-compile, etc) have a #!python shebang, which apparently does not respect the PATH variable and therefore does not necessarily find the python used in the venv. cairo-compile --version fails, but python ~/workspace/sequencer/sequencer_venv/.../cairo-compile --version does.
Code quote:
fn find_script_in_path(script_name: &str) -> Option<PathBuf> {
std::env::var_os("PATH").and_then(|paths| {
std::env::split_paths(&paths).find_map(|dir| {
let candidate = dir.join(script_name);
candidate.exists().then_some(candidate)
})
})
}
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status: 0 of 73 files reviewed, 2 unresolved discussions (waiting on Yoni-Starkware).
crates/blockifier/resources/blockifier_versioned_constants_0_14_3.json line 70 at r1 (raw file):
"os_constants": { "allowed_virtual_os_program_hashes": [ "0x39f55918423cade9e95a6a52286b56bed1c5c9b6fe39aa00301361457a3c604"
we don't want to allow old hash? or do we?
Code quote:
"0x39f55918423cade9e95a6a52286b56bed1c5c9b6fe39aa00301361457a3c604"2c74af7 to
6227306
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status: 0 of 75 files reviewed, 3 unresolved discussions (waiting on Yoni-Starkware).
crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/constants.cairo line 69 at r2 (raw file):
// Allowed virtual OS program hashes for client-side proving. const ALLOWED_VIRTUAL_OS_PROGRAM_HASHES_0 = ( 0x039f55918423cade9e95a6a52286b56bed1c5c9b6fe39aa00301361457a3c604
we don't want to allow old hash? or do we?
Code quote:
0x039f55918423cade9e95a6a52286b56bed1c5c9b6fe39aa00301361457a3c604
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 72 files and all commit messages, and made 2 comments.
Reviewable status: 72 of 75 files reviewed, 3 unresolved discussions (waiting on dorimedini-starkware).
crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/constants.cairo line 69 at r2 (raw file):
Previously, dorimedini-starkware wrote…
we don't want to allow old hash? or do we?
Oh, as long as the prev hash isn't breaking anything - we do want to keep it. You need to append the new hash
crates/blockifier/resources/blockifier_versioned_constants_0_14_3.json line 70 at r1 (raw file):
Previously, dorimedini-starkware wrote…
we don't want to allow old hash? or do we?
We do, please append
6227306 to
f95b681
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment and resolved 1 discussion.
Reviewable status: 72 of 75 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware and Yoni-Starkware).
crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/constants.cairo line 69 at r2 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Oh, as long as the prev hash isn't breaking anything - we do want to keep it. You need to append the new hash
Done.
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 6 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).
Signed-off-by: Dori Medini <dori@starkware.co>
f95b681 to
dcd17fb
Compare

No description provided.