scripts: remove unused --feeder-url from take_nodes_out_of_observer_mode#14008
scripts: remove unused --feeder-url from take_nodes_out_of_observer_mode#14008ShahakShama wants to merge 1 commit into
Conversation
The fetched block number was only used as a soft filter on the post-restart logs URL. Drop the flag and the related dead plumbing, and refresh the script title/help text to describe what the script actually does. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR SummaryLow Risk Overview The post-restart Logs Explorer link is simplified to query only for Reviewed by Cursor Bugbot for commit 14d7f04. Bugbot is set up for automated code reviews on this repo. Configure here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 14d7f04. Configure here.
| ApolloArgsParserBuilder, | ||
| ConfigValuesUpdater, | ||
| get_configmap, | ||
| get_current_block_number, |
There was a problem hiding this comment.
Unused imports left behind after dead code removal
Low Severity
The PR removes the feeder-url plumbing but leaves behind three now-unused imports: urllib.error, urllib.request, and print_colored. These were previously used by the removed get_current_block_number call and the block-number print statements, and are no longer referenced anywhere in the file.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 14d7f04. Configure here.
2 participants
The fetched block number was only used as a soft filter on the post-restart
logs URL. Drop the flag and the related dead plumbing, and refresh the script
title/help text to describe what the script actually does.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com