Exclude submodule symlinks from published crates#1596
Open
TomerStarkware wants to merge 1 commit into
Open
Conversation
cairo-native and sierra-emu have symlinks into vendor/cairo (corelib, test_data/tests_starknet/*). Since #1590 made corelib a symlink, these cannot be archived during `cargo publish` unless the submodule is checked out. Excluding them from the package lets the publish workflow succeed without fetching submodules.
Benchmarking resultsBenchmark for program
|
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.550 ± 0.132 | 11.408 | 11.818 | 5.64 ± 0.08 |
cairo-native (embedded AOT) |
2.049 ± 0.015 | 2.025 | 2.074 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.244 ± 0.108 | 2.086 | 2.404 | 1.10 ± 0.05 |
Benchmark for program dict_snapshot
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
625.0 ± 12.5 | 605.4 | 643.2 | 1.00 |
cairo-native (embedded AOT) |
1843.7 ± 43.3 | 1787.4 | 1917.8 | 2.95 ± 0.09 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1889.8 ± 52.8 | 1813.0 | 2014.4 | 3.02 ± 0.10 |
Benchmark for program factorial_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.962 ± 0.023 | 4.920 | 5.005 | 2.17 ± 0.04 |
cairo-native (embedded AOT) |
2.289 ± 0.043 | 2.214 | 2.378 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.370 ± 0.039 | 2.306 | 2.443 | 1.04 ± 0.03 |
Benchmark for program fib_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.864 ± 0.052 | 4.803 | 4.955 | 2.74 ± 0.06 |
cairo-native (embedded AOT) |
1.827 ± 0.067 | 1.733 | 1.957 | 1.03 ± 0.04 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.776 ± 0.035 | 1.741 | 1.846 | 1.00 |
Benchmark for program linear_search
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
632.9 ± 10.8 | 614.0 | 645.3 | 1.00 |
cairo-native (embedded AOT) |
1872.9 ± 54.9 | 1773.3 | 1937.8 | 2.96 ± 0.10 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1972.6 ± 39.8 | 1920.9 | 2034.7 | 3.12 ± 0.08 |
Benchmark for program logistic_map
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
522.8 ± 9.1 | 511.2 | 540.5 | 1.00 |
cairo-native (embedded AOT) |
1996.9 ± 61.4 | 1909.6 | 2122.6 | 3.82 ± 0.13 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2249.9 ± 113.6 | 2084.4 | 2387.3 | 4.30 ± 0.23 |
Benchmark results Main vs HEAD.Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude submodule symlinks from published crates
Introduces Breaking Changes?
No