Skip to content

Exclude submodule symlinks from published crates#1596

Open
TomerStarkware wants to merge 1 commit into
mainfrom
tomer/released-0.9.0-rc.6
Open

Exclude submodule symlinks from published crates#1596
TomerStarkware wants to merge 1 commit into
mainfrom
tomer/released-0.9.0-rc.6

Conversation

@TomerStarkware
Copy link
Copy Markdown
Collaborator

Exclude submodule symlinks from published crates

Introduces Breaking Changes?

No

cairo-native and sierra-emu have symlinks into vendor/cairo (corelib,
test_data/tests_starknet/*). Since #1590 made corelib a symlink, these
cannot be archived during `cargo publish` unless the submodule is
checked out. Excluding them from the package lets the publish workflow
succeed without fetching submodules.
@TomerStarkware TomerStarkware requested a review from orizi April 20, 2026 10:06
@github-actions
Copy link
Copy Markdown

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.550 ± 0.132 11.408 11.818 5.64 ± 0.08
cairo-native (embedded AOT) 2.049 ± 0.015 2.025 2.074 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 2.244 ± 0.108 2.086 2.404 1.10 ± 0.05

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 625.0 ± 12.5 605.4 643.2 1.00
cairo-native (embedded AOT) 1843.7 ± 43.3 1787.4 1917.8 2.95 ± 0.09
cairo-native (embedded JIT using LLVM's ORC Engine) 1889.8 ± 52.8 1813.0 2014.4 3.02 ± 0.10

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.962 ± 0.023 4.920 5.005 2.17 ± 0.04
cairo-native (embedded AOT) 2.289 ± 0.043 2.214 2.378 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 2.370 ± 0.039 2.306 2.443 1.04 ± 0.03

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.864 ± 0.052 4.803 4.955 2.74 ± 0.06
cairo-native (embedded AOT) 1.827 ± 0.067 1.733 1.957 1.03 ± 0.04
cairo-native (embedded JIT using LLVM's ORC Engine) 1.776 ± 0.035 1.741 1.846 1.00

Benchmark for program linear_search

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 632.9 ± 10.8 614.0 645.3 1.00
cairo-native (embedded AOT) 1872.9 ± 54.9 1773.3 1937.8 2.96 ± 0.10
cairo-native (embedded JIT using LLVM's ORC Engine) 1972.6 ± 39.8 1920.9 2034.7 3.12 ± 0.08

Benchmark for program logistic_map

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 522.8 ± 9.1 511.2 540.5 1.00
cairo-native (embedded AOT) 1996.9 ± 61.4 1909.6 2122.6 3.82 ± 0.13
cairo-native (embedded JIT using LLVM's ORC Engine) 2249.9 ± 113.6 2084.4 2387.3 4.30 ± 0.23

@github-actions
Copy link
Copy Markdown

Benchmark results Main vs HEAD.

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 2.053 ± 0.014 2.031 2.071 1.04 ± 0.01
base dict_insert.cairo (AOT) 1.979 ± 0.021 1.947 2.003 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_insert.cairo (JIT) 2.153 ± 0.026 2.112 2.181 1.04 ± 0.02
head dict_insert.cairo (AOT) 2.079 ± 0.028 2.048 2.134 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 1.786 ± 0.015 1.766 1.811 1.06 ± 0.01
base dict_snapshot.cairo (AOT) 1.692 ± 0.014 1.671 1.713 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_snapshot.cairo (JIT) 1.867 ± 0.018 1.838 1.901 1.06 ± 0.02
head dict_snapshot.cairo (AOT) 1.765 ± 0.019 1.738 1.801 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 2.183 ± 0.016 2.162 2.215 1.03 ± 0.01
base factorial_2M.cairo (AOT) 2.117 ± 0.016 2.090 2.141 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 2.314 ± 0.025 2.278 2.352 1.02 ± 0.02
head factorial_2M.cairo (AOT) 2.274 ± 0.038 2.223 2.343 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 1.737 ± 0.017 1.706 1.762 1.04 ± 0.01
base fib_2M.cairo (AOT) 1.677 ± 0.012 1.660 1.693 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 1.833 ± 0.027 1.767 1.871 1.02 ± 0.03
head fib_2M.cairo (AOT) 1.802 ± 0.037 1.763 1.864 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 1.854 ± 0.015 1.835 1.878 1.08 ± 0.01
base linear_search.cairo (AOT) 1.719 ± 0.014 1.687 1.735 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head linear_search.cairo (JIT) 1.957 ± 0.043 1.914 2.053 1.08 ± 0.03
head linear_search.cairo (AOT) 1.817 ± 0.030 1.774 1.851 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 2.015 ± 0.021 1.972 2.038 1.10 ± 0.01
base logistic_map.cairo (AOT) 1.833 ± 0.015 1.812 1.851 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 2.103 ± 0.015 2.077 2.129 1.07 ± 0.02
head logistic_map.cairo (AOT) 1.956 ± 0.039 1.912 2.049 1.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant