Conversation
|
@coderabbitai review |
📝 WalkthroughWalkthroughUpdated the package version from 1.2.3 to 1.2.4 in package.json. No changes to dependencies, scripts, configuration, or any other files. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
1-75:⚠️ Potential issue | 🔴 CriticalCritical: vault-registry.json changes are missing from this review.
The PR objectives state that
src/validators/evm/erc4626/vault-registry.jsonwas re-exported and patched with Trust's 5 OAV proxy addresses and WBNB flags for 12 BSC vaults, but this file is not included in the files for review. The core feature implementation cannot be validated without reviewing the vault registry changes.Please ensure the vault-registry.json file is included in the review context so the actual feature changes (OAV proxy addresses, WBNB patches, vault count increase from 1,468 to 1,516) can be properly validated.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 1 - 75, The vault-registry.json that you declared for re-export/patching (src/validators/evm/erc4626/vault-registry.json) is missing from this PR; add the actual JSON file to the commit so reviewers can validate the OAV proxy addresses and WBNB flag patches and the vault-count increase. Locate the file at src/validators/evm/erc4626/vault-registry.json, commit the patched JSON that includes Trust’s 5 OAV proxy addresses and WBNB flags for the 12 BSC vaults, and ensure the committed file matches the "files" entry in package.json so the change is included in the review and release artifacts.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 3: The package.json version field is incorrect (shows "1.2.4") and must
be bumped to the intended minor release "1.3.0"; open package.json, locate the
"version" property and change its value from "1.2.4" to "1.3.0" so the manifest
matches the PR objectives and semantic versioning for the new Trust OAV
allocatorVaults feature.
---
Outside diff comments:
In `@package.json`:
- Around line 1-75: The vault-registry.json that you declared for
re-export/patching (src/validators/evm/erc4626/vault-registry.json) is missing
from this PR; add the actual JSON file to the commit so reviewers can validate
the OAV proxy addresses and WBNB flag patches and the vault-count increase.
Locate the file at src/validators/evm/erc4626/vault-registry.json, commit the
patched JSON that includes Trust’s 5 OAV proxy addresses and WBNB flags for the
12 BSC vaults, and ensure the committed file matches the "files" entry in
package.json so the change is included in the review and release artifacts.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7dc01a11-b8e3-4c2f-863c-90a1a20f9d02
📒 Files selected for processing (2)
package.jsonsrc/validators/evm/erc4626/vault-registry.json
Summary by CodeRabbit
/v1/shield/registry— now includes Trust's 5 OAV proxy addresses asallocatorVaultsisWethVault: true) for 12 BSC vaults — the monorepo endpoint doesn't include BSC WBNB in its WETH address setWhy
Shield cannot validate transactions routed through Trust's OAV proxy contracts because none of the 5 proxy addresses were registered as
allocatorVaultsin the vault registry. The ERC4626 validator usesallocatorVaultsto create additional lookup entries invaultInfoMap— without them, legitimate Trust OAV transactions are rejected.Trust OAV Proxies Added
binance-u-fu-0x007df53c...-4626-vault0x5150b6c808ad8aba8242e427f612b10102ca77b8binance-u-u-0x9a17fd5c...-4626-vault0x1a89b7a36ec8993525aeeeabbe0f505e5b91fdb1ethereum-usdc-gtusdcp-0x8c106ee...-4626-vault0xd8b444ac665b0de3a9135ad7be1a45f88ac97b3cethereum-crvusd-scrvusd-0x065597...-4626-vault0x3ef5a8e7ab66b21cb81fe688e26fe45ed8cfdc27ethereum-crvusd-cvcrvusd-0x5ae28c...-4626-vault0xeb9b1598183a2fb7975076c9d4f5d64e2dd44170Files Changed
src/validators/evm/erc4626/vault-registry.jsonpackage.jsonTest Results
allocatorVaultsisWethVault: true