Android: Manuever icons driving side icons#857
Open
bjtrounson wants to merge 5 commits intostadiamaps:mainfrom
Open
Android: Manuever icons driving side icons#857bjtrounson wants to merge 5 commits intostadiamaps:mainfrom
bjtrounson wants to merge 5 commits intostadiamaps:mainfrom
Conversation
…rrect driving icon based on the side of the road the user is driving on.
Collaborator
Author
|
Need to look at the car app stuff for these as there seems to be some errors in there. |
| InstructionsView(instructions = instructions, distanceToNextManeuver = 42.0) | ||
| } | ||
|
|
||
| @Preview |
Contributor
There was a problem hiding this comment.
We should probably add some Paparazzi tests too.
Contributor
There was a problem hiding this comment.
Quick bump on this; we should have some Paparazzi snapshot tests to ensure against future regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for driving-side-specific icons for roundabouts and rotaries. This ensures that in regions with left-hand traffic, the navigation icons correctly illustrate the clockwise flow of traffic.
The implementation introduces the necessary LHD assets and updates the icon selection logic to detect the driving side, while maintaining right-hand driving (RHD) as the default fallback.