Add property tests for step advance conditions (#639)#855
Open
ianthetechie wants to merge 3 commits intomainfrom
Open
Add property tests for step advance conditions (#639)#855ianthetechie wants to merge 3 commits intomainfrom
ianthetechie wants to merge 3 commits intomainfrom
Conversation
Add 8 new property-based tests encoding key invariants of the step advance system: accuracy gating for distance conditions, off-route gating, OR/AND composite behavior with trivially true/false conditions, multi-update stateful condition stability, and snapped exit condition zero-movement safety. Replaces TODO comments with concrete tests. https://claude.ai/code/session_01Bh2XrcnBbVRBKKTRVwCz1N
ianthetechie
commented
Mar 31, 2026
| fn distance_to_end_never_advances_with_bad_accuracy( | ||
| c1 in arb_coord(), | ||
| c2 in arb_coord(), | ||
| accuracy in 11.0f64..10000.0f64, |
Contributor
Author
There was a problem hiding this comment.
We can probably drop the upper bound here.
| c1 in arb_coord(), | ||
| c2 in arb_coord(), | ||
| user_coord in arb_coord(), | ||
| accuracy in 11.0f64..10000.0f64, |
Contributor
Author
There was a problem hiding this comment.
Same as prev comment; upper bound not helpful.
Generate accuracy as threshold + arbitrary positive excess instead of a bounded range, per reviewer feedback. https://claude.ai/code/session_01Bh2XrcnBbVRBKKTRVwCz1N
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 8 new property-based tests encoding key invariants of the step
advance system: accuracy gating for distance conditions, off-route
gating, OR/AND composite behavior with trivially true/false conditions,
multi-update stateful condition stability, and snapped exit condition
zero-movement safety. Replaces TODO comments with concrete tests.
https://claude.ai/code/session_01Bh2XrcnBbVRBKKTRVwCz1N