test: allow sub-second poll time#7093
Closed
brice-stacks wants to merge 2 commits intostacks-network:developfrom
Closed
test: allow sub-second poll time#7093brice-stacks wants to merge 2 commits intostacks-network:developfrom
brice-stacks wants to merge 2 commits intostacks-network:developfrom
Conversation
I don't think there is any downside to setting this to zero for tests and it should give us some speedup.
Coverage Report for CI Build 24271162921Coverage decreased (-0.07%) to 85.644%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1960 previously-covered lines in 70 files lost coverage.
Coverage Stats
💛 - Coveralls |
poll_time_secs to 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think there is any downside to setting this to zero for tests and it should give us some speedup.Zero does not allow enough time for other threads. The second commit here allows sub-second poll time and defaults to 100ms.