Skip to content

test: allow sub-second poll time#7093

Closed
brice-stacks wants to merge 2 commits intostacks-network:developfrom
brice-stacks:test/poll_time_secs
Closed

test: allow sub-second poll time#7093
brice-stacks wants to merge 2 commits intostacks-network:developfrom
brice-stacks:test/poll_time_secs

Conversation

@brice-stacks
Copy link
Copy Markdown
Contributor

@brice-stacks brice-stacks commented Apr 10, 2026

I don't think there is any downside to setting this to zero for tests and it should give us some speedup.

Zero does not allow enough time for other threads. The second commit here allows sub-second poll time and defaults to 100ms.

I don't think there is any downside to setting this to zero for tests
and it should give us some speedup.
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 10, 2026

Coverage Report for CI Build 24271162921

Coverage decreased (-0.07%) to 85.644%

Details

  • Coverage decreased (-0.07%) from the base build.
  • Patch coverage: 18 of 18 lines across 3 files are fully covered (100%).
  • 1960 coverage regressions across 70 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1960 previously-covered lines in 70 files lost coverage.

Top 10 Files by Coverage Loss Lines Losing Coverage Coverage
stackslib/src/net/inv/epoch2x.rs 221 79.49%
stackslib/src/net/chat.rs 199 93.0%
stacks-node/src/nakamoto_node/miner.rs 137 86.85%
stackslib/src/net/api/postblock_proposal.rs 107 82.16%
stackslib/src/clarity_vm/database/marf.rs 99 60.67%
stackslib/src/net/p2p.rs 79 73.82%
clarity/src/vm/contexts.rs 75 92.36%
clarity/src/vm/functions/database.rs 75 92.36%
stackslib/src/net/codec.rs 69 91.63%
stackslib/src/clarity_vm/database/ephemeral.rs 61 56.82%

Coverage Stats

Coverage Status
Relevant Lines: 217895
Covered Lines: 186613
Line Coverage: 85.64%
Coverage Strength: 17347657.66 hits per line

💛 - Coveralls

@brice-stacks brice-stacks changed the title test: set poll_time_secs to 0 test: allow sub-second poll time Apr 11, 2026
@brice-stacks brice-stacks marked this pull request as draft April 11, 2026 01:45
@brice-stacks brice-stacks deleted the test/poll_time_secs branch April 13, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants