fix: Change timeouts to fix flaky tests miner_stackerdb_version_rollover and multiple_miners_mock_sign_epoch_25#7092
Open
jbencin-stacks wants to merge 2 commits intostacks-network:developfrom
Conversation
…ot_to_epoch_25_reward_cycle`
Coverage Report for CI Build 24255616294Coverage decreased (-0.04%) to 85.673%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1886 previously-covered lines in 63 files lost coverage.
Coverage Stats
💛 - Coveralls |
Contributor
francesco-stacks
left a comment
There was a problem hiding this comment.
Changes look fine, but the test multiple_miners_mock_sign_epoch_25 is still failing, could also bump
wait_for_registered and boot_to_epoch_25_reward_cycleminer_stackerdb_version_rollover and multiple_miners_mock_sign_epoch_25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix flaky tests I observed while working on #6981:
wait_for_registered: Changesleep()andsend_status_request()args to match other testsmultiple_miners_mock_sign_epoch_25: Increase timeout to matchboot_to_epoch_3Additional info (benefits, drawbacks, caveats)
It's hard to know if this change will solve the flakiness 100%, it's basically applying patterns from non-flaky tests and previously fixed flaky tests
Checklist
changelog.d/README.md)