Skip to content

fix: Change timeouts to fix flaky tests miner_stackerdb_version_rollover and multiple_miners_mock_sign_epoch_25#7092

Open
jbencin-stacks wants to merge 2 commits intostacks-network:developfrom
jbencin-stacks:fix/flaky-tests
Open

fix: Change timeouts to fix flaky tests miner_stackerdb_version_rollover and multiple_miners_mock_sign_epoch_25#7092
jbencin-stacks wants to merge 2 commits intostacks-network:developfrom
jbencin-stacks:fix/flaky-tests

Conversation

@jbencin-stacks
Copy link
Copy Markdown

@jbencin-stacks jbencin-stacks commented Apr 10, 2026

Description

Fix flaky tests I observed while working on #6981:

  • wait_for_registered: Change sleep() and send_status_request() args to match other tests
  • multiple_miners_mock_sign_epoch_25: Increase timeout to match boot_to_epoch_3

Additional info (benefits, drawbacks, caveats)

It's hard to know if this change will solve the flakiness 100%, it's basically applying patterns from non-flaky tests and previously fixed flaky tests

Checklist

  • Changelog fragment(s) or "no changelog" label added (see changelog.d/README.md)
  • Run each test 10 times locally to test. No failures

Copy link
Copy Markdown
Contributor

@brice-stacks brice-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jbencin-stacks jbencin-stacks marked this pull request as ready for review April 10, 2026 20:22
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 24255616294

Coverage decreased (-0.04%) to 85.673%

Details

  • Coverage decreased (-0.04%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 1886 coverage regressions across 63 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1886 previously-covered lines in 63 files lost coverage.

Top 10 Files by Coverage Loss Lines Losing Coverage Coverage
stackslib/src/net/inv/epoch2x.rs 214 79.84%
stackslib/src/net/chat.rs 205 92.87%
stacks-node/src/nakamoto_node/miner.rs 134 87.08%
stackslib/src/net/api/postblock_proposal.rs 102 82.89%
stackslib/src/clarity_vm/database/marf.rs 99 60.67%
clarity/src/vm/contexts.rs 75 92.36%
clarity/src/vm/functions/database.rs 75 92.36%
stackslib/src/net/codec.rs 69 91.63%
stackslib/src/net/p2p.rs 65 75.09%
stackslib/src/clarity_vm/database/ephemeral.rs 61 56.82%

Coverage Stats

Coverage Status
Relevant Lines: 217886
Covered Lines: 186670
Line Coverage: 85.67%
Coverage Strength: 17064302.84 hits per line

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@francesco-stacks francesco-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, but the test multiple_miners_mock_sign_epoch_25 is still failing, could also bump

to 240 secs? seems this is the place where it is now failing

@jbencin-stacks jbencin-stacks changed the title fix: Change timeouts to fix flaky tests wait_for_registered and boot_to_epoch_25_reward_cycle fix: Change timeouts to fix flaky tests miner_stackerdb_version_rollover and multiple_miners_mock_sign_epoch_25 Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants