ROX-33443: Fix interactive legend click in Victory v37#19278
Draft
sachaudh wants to merge 1 commit intodv/ROX-28622-pf-6from
Draft
ROX-33443: Fix interactive legend click in Victory v37#19278sachaudh wants to merge 1 commit intodv/ROX-28622-pf-6from
sachaudh wants to merge 1 commit intodv/ROX-28622-pf-6from
Conversation
Victory v37 (PF charts v8) broke getInteractiveLegendEvents -- the onLegendClick callback passed through Chart's events prop is never invoked. Work around this by attaching click events directly to the ChartLegend component instead. Also fixes chartNames ordering to match legend item indices and adds name props to ChartBar for correct hover muting behavior. Partially generated by AI. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at f801627. To use with deploy scripts, first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jira: ROX-33443
Victory v37 (PF charts v8) broke
getInteractiveLegendEvents-- theonLegendClickcallback passed throughChart'seventsprop is never invoked. This PR works around the issue by attaching click events directly to theChartLegendcomponent.ChartLegendvia itseventsprop, bypassing the brokenChart-level event propagationchartNamesordering to match legend item indices (was usingObject.values()which followed object declaration order instead of the array order used by the legend)nameprop toChartBarcomponents so the interactive legend can target chart children for hover effectsUser-facing documentation
Testing and quality
Automated testing
How I validated my change
Screenshots