ROX-33419: Replace frontend SCANNABLE with Scan Status search filter#19277
ROX-33419: Replace frontend SCANNABLE with Scan Status search filter#19277pedrottimark wants to merge 1 commit intomasterfrom
Conversation
|
Images are ready for the commit at 3cc7e4e. To use with deploy scripts, first |
1 similar comment
|
Images are ready for the commit at 3cc7e4e. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19277 +/- ##
==========================================
- Coverage 49.62% 49.62% -0.01%
==========================================
Files 2679 2680 +1
Lines 202138 202195 +57
==========================================
+ Hits 100306 100331 +25
- Misses 94356 94388 +32
Partials 7476 7476
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@pedrottimark: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Fix one item of residue described in #19002
Problems
Although backend seems to use case insensitive match for search field label:
Analysis
Because vulnerabilities for virtual machines might become generally available in next release, replace now.
Solution
Replace occurrences of scannable with scan status for consistency.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.npm run startin ui/apps/platform folder with instance that has virtual machines.Manual testing
TODO