Skip to content

ROX-33419: Replace frontend SCANNABLE with Scan Status search filter#19277

Open
pedrottimark wants to merge 1 commit intomasterfrom
ROX-33419-SCANNABLE-Scan-Status
Open

ROX-33419: Replace frontend SCANNABLE with Scan Status search filter#19277
pedrottimark wants to merge 1 commit intomasterfrom
ROX-33419-SCANNABLE-Scan-Status

Conversation

@pedrottimark
Copy link
Contributor

Description

Fix one item of residue described in #19002

Problems

Although backend seems to use case insensitive match for search field label:

  • Use consistent Title Case for search field.
  • Inconsistent UPPERCASE risks misleading results from Find in Files.

Analysis

Because vulnerabilities for virtual machines might become generally available in next release, replace now.

Solution

Replace occurrences of scannable with scan status for consistency.

User-facing documentation

  • CHANGELOG.md update is not needed
  • documentation PR is not needed

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  1. npm run tsc in ui/apps/platform folder.
  2. npm run lint:fast-dev in ui/apps/platform folder.
  3. npm run start in ui/apps/platform folder with instance that has virtual machines.

Manual testing

TODO

@pedrottimark pedrottimark requested a review from bradr5 March 3, 2026 21:32
@pedrottimark pedrottimark requested a review from a team as a code owner March 3, 2026 21:32
@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 3cc7e4e.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-223-g3cc7e4ee84.

1 similar comment
@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 3cc7e4e.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-223-g3cc7e4ee84.

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.62%. Comparing base (8c7ae09) to head (3cc7e4e).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19277      +/-   ##
==========================================
- Coverage   49.62%   49.62%   -0.01%     
==========================================
  Files        2679     2680       +1     
  Lines      202138   202195      +57     
==========================================
+ Hits       100306   100331      +25     
- Misses      94356    94388      +32     
  Partials     7476     7476              
Flag Coverage Δ
go-unit-tests 49.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2026

@pedrottimark: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-20-ui-e2e-tests 3cc7e4e link false /test ocp-4-20-ui-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants