Skip to content

fix: support helm chart import-values#1112

Merged
janisz merged 2 commits intostackrox:mainfrom
emmanuel-ferdman:fix-helm-import-values
Mar 10, 2026
Merged

fix: support helm chart import-values#1112
janisz merged 2 commits intostackrox:mainfrom
emmanuel-ferdman:fix-helm-import-values

Conversation

@emmanuel-ferdman
Copy link
Copy Markdown
Contributor

@emmanuel-ferdman emmanuel-ferdman commented Feb 28, 2026

PR Summary

When linting helm charts that use import-values to pull values from subcharts, kube-linter was failing with a nil pointer error because those imported values were never actually loaded. This PR adds a call to ProcessDependencies before rendering templates, which is what helm itself does in its template.go.

Fixes #1111

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.44%. Comparing base (dbd7529) to head (6b3587f).
⚠️ Report is 255 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1112       +/-   ##
===========================================
- Coverage   62.36%   29.44%   -32.92%     
===========================================
  Files         197      237       +40     
  Lines        4854     6452     +1598     
===========================================
- Hits         3027     1900     -1127     
- Misses       1439     4385     +2946     
+ Partials      388      167      -221     
Flag Coverage Δ
unit 29.44% <100.00%> (-32.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@janisz janisz self-assigned this Mar 9, 2026
@janisz
Copy link
Copy Markdown
Collaborator

janisz commented Mar 9, 2026

@emmanuel-ferdman nice, could you add a unit test of e2e test to verify it?

@janisz janisz added the bug Something isn't working label Mar 9, 2026
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@janisz janisz merged commit e6d1b56 into stackrox:main Mar 10, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] kube-linter fails but helm template doesn't

2 participants