fix: support helm chart import-values#1112
Merged
janisz merged 2 commits intostackrox:mainfrom Mar 10, 2026
Merged
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1112 +/- ##
===========================================
- Coverage 62.36% 29.44% -32.92%
===========================================
Files 197 237 +40
Lines 4854 6452 +1598
===========================================
- Hits 3027 1900 -1127
- Misses 1439 4385 +2946
+ Partials 388 167 -221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@emmanuel-ferdman nice, could you add a unit test of e2e test to verify it? |
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
janisz
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
When linting helm charts that use
import-valuesto pull values from subcharts, kube-linter was failing with anil pointererror because those imported values were never actually loaded. This PR adds a call toProcessDependenciesbefore rendering templates, which is what helm itself does in itstemplate.go.Fixes #1111