You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This change enables post-quantum key-exchange algorithms for OpenSSL. As fact uses the image crypto libraries and does not hardcode TLS settings, this should enable ML-KEM key exchanges it.
As fact uses the image crypto libraries and does not hardcode TLS settings, this should enable ML-KEM key exchanges it.
Have you done any manual testing to validate this? I know a few months back I tried capturing some packets with tcpdump and inspecting them with WireShark. If so, mind updating the Testing Performed section in the PR description?
As fact uses the image crypto libraries and does not hardcode TLS settings, this should enable ML-KEM key exchanges it.
Have you done any manual testing to validate this? I know a few months back I tried capturing some packets with tcpdump and inspecting them with WireShark. If so, mind updating the Testing Performed section in the PR description?
Yes, I wasn't finished with the testing, now it's done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change enables post-quantum key-exchange algorithms for OpenSSL. As
factuses the image crypto libraries and does not hardcode TLS settings, this should enable ML-KEM key exchanges it.See also: stackrox/collector#2977
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
In the fact container (before this PR):
In the sensor logs:
❌ X25519 is not a PQC key exchange algorithm
In the fact container (after this PR):
In the sensor logs:
✅ X25519MLKEM768 is a PQC key exchange algorithm