Conversation
…ENSE.md; fix sqlite-memory.c to load extension only when it is statically linked
…ine LLAMA options and link flags for macOS, iOS, and Android
…and improve platform detection
…onditions and improve command execution
…ch to avoid shell escaping issues with PLIST/MODULEMAP
| rc = SQLITE_OK; | ||
| } | ||
|
|
||
| // explicitly allows extension loading (only when loaded dynamically) |
There was a problem hiding this comment.
I had to conditionally enable load extensions because when compiled without sqlite3.c it was giving me this error
Undefined symbols for architecture arm64:
"_sqlite3_enable_load_extension", referenced from:
_sqlite3_memory_init in sqlite-memory.o
ld: symbol(s) not found for architecture arm64
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
| int dbmem_compute_uuid_v7 (uint8_t value[DBMEM_UUID_LEN]) { | ||
| // fill the buffer with high-quality random data | ||
| #ifdef _WIN32 | ||
| if (BCryptGenRandom(NULL, (BYTE*)value, DBMEM_UUID_LEN, BCRYPT_USE_SYSTEM_PREFERRED_RNG) != STATUS_SUCCESS) return -1; |
There was a problem hiding this comment.
STATUS_SUCCESS was undefined on Windows
There was a problem hiding this comment.
I've added the LICENSE file because to compile the Android AAR package is needed, otherwise it trows errors. Feel free to change the license to everything else, I've copied this one from the other extensions license.
There was a problem hiding this comment.
In the tests I've just changed the directory for the test files since on Windows and Android the /tmp directory is unavailable. Everything else remains unchanged.
There was a problem hiding this comment.
Some platforms required the sqlite3.h file to compile since they don't have the system one available.
2 participants
No description provided.