fix: envsubst and payload construction for staging deploy#165
Merged
Conversation
akandic47
requested review from
MakMuftic,
mpetrun5,
mpetrunic and
tcar121293
as code owners
envsubst was expanding all ${} patterns including container runtime
variables like ${SYG_RELAYER_MPCCONFIG_KEYSHAREPATH}. Restrict to
only workflow-defined variables. Also replace fragile echo-based JSON
payload construction with jq --rawfile to handle special characters
in KEYSHARE JSON values.
akandic47
force-pushed
the
chore/migrate-staging-env-vars
branch
from
d8da473 to
f62459b
Compare
mpetrun5
approved these changes
Mar 27, 2026
|
Go Test coverage is 53.1 %\ ✨ ✨ ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
envsubstto only substitute workflow-defined variables, preventing expansion of container runtime variables like${SYG_RELAYER_MPCCONFIG_KEYSHAREPATH}echo-based JSON payload construction withjq --rawfileto safely handle special characters in KEYSHARE JSON valuesTest plan
envsubstwith explicit var list preserves$${SYG_RELAYER_MPCCONFIG_KEYSHAREPATH}in command sectionjq --rawfileproduces valid JSON payload with embedded compose content