Introduce explicit index field matching methods#5192
Open
DragonFSKY wants to merge 1 commit intospring-projects:mainfrom
Open
Introduce explicit index field matching methods#5192DragonFSKY wants to merge 1 commit intospring-projects:mainfrom
DragonFSKY wants to merge 1 commit intospring-projects:mainfrom
Conversation
Closes spring-projects#5187 Signed-off-by: dragonfsky <dragonfsky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5187
This PR follows the defensive path proposed in the issue discussion for
IndexInfo.isIndexForFields(Collection<String>).The existing method is deprecated but keeps its current subset-matching behavior for compatibility. The PR introduces explicit alternatives for the different matching semantics:
containsAllFields(Collection<String>)for subset matching regardless of index field positionisIndexForFieldsExactly(Collection<String>)for exact field-name matching regardless of ordercoversFields(Collection<String>)for compound-index prefix coverageIt also updates an internal test helper to use
containsAllFields(Collection<String>)instead of the deprecated method.Tested with:
./mvnw -s settings.xml -pl spring-data-mongodb clean test -Dtest=IndexInfoUnitTestsChecklist: