Restrict implicit id mapping to document types#5191
Open
DragonFSKY wants to merge 1 commit intospring-projects:mainfrom
Open
Restrict implicit id mapping to document types#5191DragonFSKY wants to merge 1 commit intospring-projects:mainfrom
DragonFSKY wants to merge 1 commit intospring-projects:mainfrom
Conversation
Closes spring-projects#3351 Signed-off-by: dragonfsky <dragonfsky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3351
This PR introduces an opt-in setting on
MongoMappingContextto restrict implicitidto_idmapping to types annotated with@Document.The default remains unchanged to preserve the existing behavior for compatibility. Explicit
@Idmappings continue to be recognized regardless of the owning type.The change includes coverage for:
idpathsidpaths and valuesTested with:
./mvnw -s settings.xml -pl spring-data-mongodb clean test -Dtest=BasicMongoPersistentPropertyUnitTests,MappingMongoConverterUnitTests,QueryMapperUnitTests,UpdateMapperUnitTestsChecklist: