Rename ActiveMQ docker image

[eddumelendez]

From apache/activemq-classic to apache/activemq.
See https://lists.apache.org/list.html?dev@activemq.apache.org

Signed-off-by: Eddú Meléndez eddu.melendez@gmail.com

[mhalbritter]

Hello,

that change leads to this failure:

Caused by: java.lang.IllegalStateException: Failed to verify that image 'apache/activemq:latest' is a compatible substitute for 'apache/activemq-classic'. This generally means that you are trying to use an image that Testcontainers has not been designed to use. If this is deliberate, and if you are confident that the image is compatible, you should declare compatibility in code using the `asCompatibleSubstituteFor` method. For example:
   DockerImageName myImage = DockerImageName.parse("apache/activemq:latest").asCompatibleSubstituteFor("apache/activemq-classic");
and then use `myImage` instead.
	at org.testcontainers.utility.DockerImageName.assertCompatibleWith(DockerImageName.java:279) ~[testcontainers-2.0.3.jar:2.0.3]
	at org.testcontainers.activemq.ActiveMQContainer.<init>(ActiveMQContainer.java:48) ~[testcontainers-activemq-2.0.3.jar:na]
	at com.example.demo.TestcontainersConfiguration.activemqContainer(TestcontainersConfiguration.java:15) ~[test/:na]
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:na]
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[na:na]
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:na]
	at java.base/java.lang.reflect.Method.invoke(Method.java:569) ~[na:na]
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.lambda$instantiate$0(SimpleInstantiationStrategy.java:155) ~[spring-beans-7.0.5.jar:7.0.5]
	... 44 common frames omitted

Is this something which will be fixed in Testcontainers?

[eddumelendez]

We should wait until next Testcontainers release to support compatibility with that new image. That means it will be compatible with latest spring boot project, once the dependency is updated.

[eddumelendez]

Testcontainers 2.0.4 contains the change for this. Once Spring Boot updates the version, this change can be merged, I think it will apply for 4.1.0-M3

[mhalbritter]

Yes, it now works with 4.0.4 and 4.1.0-M3 because they use Testcontainers 2.0.4. This leaves 3.5.x as broken. Are you able to fix the PR so that it only applies to 4.0.x and up?

[eddumelendez]

PR updated

[mhalbritter]

Thanks @eddumelendez !