fix: correct targeting payload format in migration skill#15
Merged
Conversation
nicklasl
approved these changes
May 25, 2026
vahidlazio
force-pushed
the
fix/targeting-payload-format
branch
from
f068245 to
5096f79
Compare
The Confidence Targeting proto uses a criteria/expression pattern with named references, not nested rule objects. The old format was silently parsed as empty targeting (matching all contexts) due to ignoringUnknownFields() in the proto parser. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vahidlazio
force-pushed
the
fix/targeting-payload-format
branch
from
5096f79 to
2e58c68
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/migrate-posthog/SKILL.mdto use the correct Confidence Targeting proto format (criteria/expressionwith namedrefreferences){"or": {"operands": [{"eqRule": ...}]}}) which was silently parsed as empty targeting by the proto parser'signoringUnknownFields(), creating rules that matched ALL contextsTest plan
/migrate-posthog executeand confirm targeting rules have actual conditions (not match-all)🤖 Generated with Claude Code