Draft
Conversation
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
commented
Mar 18, 2026
| // Poll event loop until outgoing publish event is iterated over to send the message to MQTT broker or capture/throw error. | ||
| // We may revisit this later to manage long running connections, high throughput use cases and their issues in the connection pool. | ||
| let mut lock = self.event_loop.lock().await; | ||
| loop { |
Collaborator
Author
There was a problem hiding this comment.
I am not sure what to do about this. Reading the code this seems like it would block further publish attempts until the previous one has resolved, which can't be the intention.
Maybe we need to redesign this to run an always-on background polling task, figure out how to link completions with publishes, and then do some future-based way to report errrors. I don't know MQTT well enough to be confident with any of this though...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in here:
What's not in here: